Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

z_sendmany fails with the fee field set to null for Sapling-to-Orchard with Orchard change #6956

Open
str4d opened this issue Oct 1, 2024 · 1 comment
Open

z_sendmany fails with the fee field set to null for Sapling-to-Orchard with Orchard change #6956

str4d opened this issue Oct 1, 2024 · 1 comment
Labels
A-wallet Area: Wallet
Milestone
Release 6.2.0

Comments

@str4d
Copy link
Contributor

str4d commented Oct 1, 2024 •
edited
Loading

Found in the wallet_orchard_change RPC test while migrating it to ZIP 317. The null gets re-calculated as a 3-logical-action fee, but the actually-created transaction has 4 logical actions.
@str4d str4d added the A-wallet Area: Wallet label Oct 1, 2024
daira added a commit to daira/zcash that referenced this issue Oct 2, 2024
@daira
Add a regression test for the ZIP 317 default fee bug (zcash#6956), a…
05ed3da 
…nd make

the tests pass for now.

Signed-off-by: Daira-Emma Hopwood <[email protected]>
@daira daira added this to the Release 6.1.0 milestone Oct 2, 2024
daira added a commit to daira/zcash that referenced this issue Oct 2, 2024
@daira
Add a regression test for the ZIP 317 default fee bug (zcash#6956), a…
dd79138 
…nd make

the tests pass for now.

Signed-off-by: Daira-Emma Hopwood <[email protected]>
@daira
Copy link
Contributor

daira commented Oct 2, 2024

There is a similar case in the wallet_isfromme RPC test.

@str4d str4d modified the milestones: Release 6.0.1, Release 6.1.0 Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-wallet Area: Wallet
Projects
None yet
Milestone
Release 6.2.0
Development

No branches or pull requests
2 participants
@daira @str4d