-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependabot: ingore OPA updates #3334
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We decided to ignore automatically updating OPA dependencies. It was already done in #3332 (comment) & #3320 (comment) This PR is to add visibility and we will run `@dependabot unignore ...` after merging. See [`ignore` docs](https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#ignore) Signed-off-by: Mustafa Abdelrahman <[email protected]>
👍 |
1 similar comment
👍 |
This was referenced Dec 6, 2024
Looking at #3346 I see it tries to update github.com/envoyproxy/go-control-plane - could you please check whether it is related or independent from OPA dependencies?
|
MustafaSaber
added a commit
that referenced
this pull request
Dec 19, 2024
follow up on #3334 [ ] unignore `github.com/envoyproxy/go-control-plane` Signed-off-by: Mustafa Abdelrahman <[email protected]>
1 task
MustafaSaber
added a commit
that referenced
this pull request
Dec 19, 2024
follow up on #3334 - [ ] unignore `github.com/envoyproxy/go-control-plane` Signed-off-by: Mustafa Abdelrahman <[email protected]>
MustafaSaber
added a commit
that referenced
this pull request
Dec 19, 2024
follow up on #3334 - [ ] unignore `github.com/envoyproxy/go-control-plane` Signed-off-by: Mustafa Abdelrahman <[email protected]>
MustafaSaber
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Dec 23, 2024
* zalando/skipper#3323 * zalando/skipper#3334 * zalando/skipper#3330 * zalando/skipper#3341 * zalando/skipper#3344 * zalando/skipper#3348 * zalando/skipper#3318 * zalando/skipper#3347 * zalando/skipper#3345 * zalando/skipper#3337 * zalando/skipper#3342 * zalando/skipper#3351 * zalando/skipper#3335 * zalando/skipper#3338 follow up on #8587 Signed-off-by: Mustafa Abdelrahman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided to ignore automatically updating OPA dependencies. It was already done in #3332 (comment) & #3320 (comment)
This PR is to add visibility and we will run
@dependabot unignore ...
after merging.github.com/open-policy-agent/opa-envoy-plugin
- see build(deps): bump the all-go-mod-patch-and-minor group across 1 directory with 14 updates #3333 (comment)github.com/open-policy-agent/opa
- see build(deps): bump the all-go-mod-patch-and-minor group across 1 directory with 14 updates #3333 (comment)See
ignore
docs