Ensure edited file's attributes remain intact #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get latest changes from yonaskolb
|
Great, thanks @maxchuquimia! Could you add a changelog entry as well? |
|
Resolves #11 |
|
@yonaskolb done :) |
yonaskolb
reviewed
Dec 2, 2019
CHANGELOG.md
Outdated
| @@ -1,6 +1,7 @@ | |||
| # Change Log | |||
|
|
|||
| ## Next Version | |||
| - Fixed edit command removes file attributes #11 @maxchuquimia | |||
There was a problem hiding this comment.
Suggested change
| - Fixed edit command removes file attributes #11 @maxchuquimia | |
| - Fixed edit command removing file attributes #46 @maxchuquimia |
yonaskolb
approved these changes
Dec 2, 2019
|
Thanks @maxchuquimia! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a case where I create a Swift/Beak script and run
chmod +xon it so that I can use it as a normal command (with#!/usr/bin/env beak run --pathtoo)I found that if I
beak edit -pthe file (amazing, by the way), upon committing the changes the file is no longer executable so I need tochmod +xagain.I've made this change and it works, however please let me know if there's a better, more PathKit-y way that you would do this☺️