Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental move feature #357

Open
wants to merge 55 commits into
base: main
Choose a base branch
from
Open

Experimental move feature #357

wants to merge 55 commits into from

Conversation

dmonad
Copy link
Member

@dmonad dmonad commented Dec 8, 2021

@zxch3n
Copy link

zxch3n commented Dec 13, 2021

Furthermore, it should be possible to move content to another shared type. This can be helpful when you want to move a type from one Y.Array to another.

🤯 Does this mean it will be able to resolve the parent-children loop?

For example, original content is

[
    {
      id: "A",
      children: [],
    },
    {
      id: "B",
      children: [],
    }
]

user0 and user1 concurrently move the content. user0 moved A inside B

[{
  id: "B",
  children: [
    {
      id: "A",
      children: [],
    },
  ]
}]

and user1 moved B inside A

[{
  id: "A",
  children: [
    {
      id: "B",
      children: [],
    },
  ]
}]

@marbemac
Copy link

marbemac commented Apr 19, 2022

Hi Kevin, very exciting that "move" is on your radar! I understand you're focused on moving ranges within a Y.Array in this PR - is re-parenting ala https://discuss.yjs.dev/t/moving-elements-in-lists/92/14 in the realm of possibility at some point (I know, nobody likes dates, just in general :)).

@dmonad
Copy link
Member Author

dmonad commented Apr 20, 2022

Hi @marbemac,

That's a huge one.. It is definitely not in scope for the initial release. Eventually, yes, I'd like to support that. However, I feel there are more important things to work on right now, so I can't give a timeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants