Improve convert_chunk_header for YAML options #2300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise some precision digits will be added, and `fig.width = 10` should be `fig-width: 10` and not `fig-width: 10.0`
yihui
approved these changes
Oct 20, 2023
I figured you would want to do that 😅 Sorry I got lazy and it was easier to write another function for me 🙄 😄 |
yihui
approved these changes
Oct 20, 2023
yihui
approved these changes
Oct 20, 2023
| any::rcmdcheck | ||
| XML=?ignore-before-r=4.0.0 |
There was a problem hiding this comment.
Not sure why, but this doesn't seem to work: https://github.com/yihui/knitr/actions/runs/6591830453/job/17911237979
There was a problem hiding this comment.
I think it probably requires to indicate the highest deps that requires it, which in our case is gridSVG. I tried a commit with this
|
Thanks a lot for the fixes ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-and not.for options namedevanddpiThis also fix an issue with numeric conversion because
yaml::as_yamlto consider a precision that we don't want here I believe.