sql engine now correctly prints table with NA in first column

Previously, `diff()` would return `NA` which does not work with `==` for comparaison. closes #2207
yihui · Jan 3, 2023 · ec4d685 · yihui · Jan 3, 2023 · cderv
1 parent b1ce0c7
commit ec4d685
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: knitr
 Type: Package
 Title: A General-Purpose Package for Dynamic Report Generation in R
-Version: 1.41.7
+Version: 1.41.8
 Authors@R: c(
     person("Yihui", "Xie", role = c("aut", "cre"), email = "[email protected]", comment = c(ORCID = "0000-0003-0645-5666")),
     person("Abhraneel", "Sarma", role = "ctb"),

diff --git a/NEWS.md b/NEWS.md
@@ -22,6 +22,10 @@
 
 - Devices from the package **cairoDevice** (`Cairo_pdf`, `Cairo_png`, `Cairo_ps`, `Cairo_svg`) are no longer supported since the package has been archived on CRAN for more than a year (thanks, @jessekps, #2204).
 
+## BUG FIXES
+
+- sql engine now correctly prints table with `NA` in first column (thanks, @mariusbommert, #2207)
+
 # CHANGES IN knitr VERSION 1.41
 
 ## NEW FEATURES

diff --git a/R/engine.R b/R/engine.R
@@ -661,7 +661,7 @@ eng_sql = function(options) {
 
       # force left alignment if the first column is an incremental id column
       first_column = display_data[[1]]
-      if (is.numeric(first_column) && length(first_column) > 1 && all(diff(first_column) == 1))
+      if (is.numeric(first_column) && length(first_column) > 1 && all(identical(diff(first_column), 1)))
         display_data[[1]] = as.character(first_column)
 
       # wrap html output in a div so special styling can be applied