Feature: Interactive update #1444

torifat · 2016-10-25T15:10:26Z

This is similar to npm-check interactive update mode. It provides an easy way to update outdated packages.

$ yarn upgrade-interactive

Currently, there is no test with this PR. But, If someone can guide me with some scenarios, I will write them, Thanks.

cpojer · 2016-10-26T01:35:36Z

This is great, I think we should add this to Yarn.

Daniel15 · 2016-10-26T04:08:34Z

yarn.lock

 rx-lite@^3.1.2:
  version "3.1.2"
  resolved "https://registry.yarnpkg.com/rx-lite/-/rx-lite-3.1.2.tgz#19ce502ca572665f3b647b10939f97fd1615f102"

+rx@^4.1.0:


rx is very large, I wonder how we feel about pulling it into Yarn. How much does this increase the installed size of Yarn? (you can run scripts\build-dist.sh on Linux/Mac or scripts\build-dist.ps1 on Windows and compare the size of the dist directory before and after your change)

3409098 - 2831040 = 578058 bytes increased 😭

It seems it can be reduced by loading only necessary modules from rx in Inquirer.js.

https://github.com/SBoudrias/Inquirer.js/search?utf8=%E2%9C%93&q=rx

Hmm, maybe this is okay for now and the size increase is offset by the usefulness of the feature. I'll see what others on the team think!

Daniel15 · 2016-10-26T04:08:48Z

This is probably my favourite pull request ever. Thank you! ❤️

andyeskridge · 2016-10-26T14:46:08Z

src/cli/aliases.js

@@ -28,7 +28,7 @@ export default ({
  rm: 'remove',
  show: 'info',
  uninstall: 'remove',
-  update: 'upgrade',
+  udpate: 'update',


A tiny typo: 'udpate' -> 'update'

The typo is intentional. That file is full of misspellings and alternate commands people are used to and are used to provide corrections.

sebmck · 2016-10-27T16:24:06Z

src/cli/commands/update.js

+
+    return ({name, current, wanted, latest, hint});
+  })))
+  .filter(({latest, current}) => latest !== current)


Instead of chaining can we assign these to variables with descriptive names, kind of hard to follow

Did you mean assign the output in a variable then filter it?

sebmck · 2016-10-27T16:24:48Z

src/cli/commands/update.js

+  const getNameFromHint = (hint) => hint ? `${hint}Dependencies` : 'dependencies';
+
+  const maxLengthArr = outdatedDeps.reduce(
+    (acc, dep) =>


I find this code really hard to follow, could we do the same here

sebmck · 2016-11-11T18:42:26Z

Merged and will be available in the next release. I've renamed the command from update to upgrade-interactive because having two commands called upgrade and update is confusing. It's not the ideal name but we want to cut a release soon and I'd love to get this in. Happy to accept a PR renaming it to something else.

AlicanC · 2016-11-11T18:46:00Z

yarn upgrade -i?

sebmck · 2016-11-11T20:38:52Z

Considered that but I think relegating this sort of functionality to an argument makes it seem less important. I think this feature is crazy awesome and deserving of it's own command.

torifat · 2016-11-11T20:43:37Z

Need to update the outdated condition. Outdated command usage semver package now.

ccorcos · 2016-11-15T20:14:49Z

what do the colors indicate?

Jessidhia · 2016-11-16T01:12:39Z

IIUC, yellow is for packages installed at their package.json version, while red is for packages that don't even match the current package.json (e.g. not installed).

This makes it so that `yarn upgrade` can upgrade all dependencies. `yarn upgrade-interactive` can be used for major version bumps. See the following: * https://yarnpkg.com/lang/en/docs/dependency-versions/#toc-caret-ranges * https://yarnpkg.com/docs/cli/upgrade/ * yarnpkg/yarn#1444 (comment)

bobmoff · 2017-04-30T08:57:49Z

is there a reason for upgrade-interactive not being in the documentation? seems like a hidden gem.

Daniel15 · 2017-05-07T03:57:06Z

It's likely that it's just because nobody has written docs for it yet. Pull requests are appreciated :)

bobmoff · 2017-05-07T10:03:18Z

@Daniel15 tried updating the documentation by cloning the website repo and running it on my dev machine, but as I have no experience with Jekyll I could not get it fully working. I updated all the places I could find but the sidebar would still not show a link to the new page so I am stuck. :(

Edit: Seems like there is something wrong with the auto-regeneration. When I manually built it, it detected all the changes and it looks ok. Will send a PR with updated docs for this awesome feature

tommedema · 2019-01-23T05:50:41Z

Is there a way to detect unused dependencies with yarn?

This makes it so that `yarn upgrade` can upgrade all dependencies. `yarn upgrade-interactive` can be used for major version bumps. See the following: * https://yarnpkg.com/lang/en/docs/dependency-versions/#toc-caret-ranges * https://yarnpkg.com/docs/cli/upgrade/ * yarnpkg/yarn#1444 (comment)

torifat force-pushed the feature/update branch from 8eff9b1 to 7e5c520 Compare October 25, 2016 15:25

Daniel15 reviewed Oct 26, 2016

View reviewed changes

andyeskridge reviewed Oct 26, 2016

View reviewed changes

vinnymac mentioned this pull request Oct 26, 2016

Support yarn as an alternative to npm dylang/npm-check#195

Open

sebmck suggested changes Oct 27, 2016

View reviewed changes

torifat force-pushed the feature/update branch from 7e5c520 to 264ccc4 Compare October 27, 2016 16:48

Add interactive update

c6bd30b

torifat force-pushed the feature/update branch from 264ccc4 to c6bd30b Compare October 27, 2016 17:01

torifat added 2 commits October 27, 2016 23:01

Simplify some obscure code

57c804a

Fix wrong const name

14fe80f

sebmck merged commit 14fe80f into yarnpkg:master Nov 11, 2016

torifat deleted the feature/update branch November 11, 2016 22:25

torifat mentioned this pull request Nov 11, 2016

Update outdated condition in upgrade-interactive #1791

Merged

azat-io mentioned this pull request Jan 20, 2017

Yarn upgrade-interactive ohmyzsh/ohmyzsh#5796

Merged

josephfrazier mentioned this pull request Mar 10, 2017

Use caret ranges in package.json, upgrade deps OctoLinker/OctoLinker#312

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: Interactive update #1444

Feature: Interactive update #1444

torifat commented Oct 25, 2016 •

edited by cpojer

Loading

cpojer commented Oct 26, 2016

Daniel15 Oct 26, 2016

torifat Oct 26, 2016 •

edited

Loading

torifat Oct 26, 2016

Daniel15 Oct 26, 2016

Daniel15 commented Oct 26, 2016

andyeskridge Oct 26, 2016

sebmck Oct 26, 2016

andyeskridge Oct 26, 2016

sebmck Oct 27, 2016

torifat Oct 27, 2016

sebmck Oct 27, 2016

sebmck commented Nov 11, 2016

AlicanC commented Nov 11, 2016

sebmck commented Nov 11, 2016

torifat commented Nov 11, 2016

ccorcos commented Nov 15, 2016

Jessidhia commented Nov 16, 2016

bobmoff commented Apr 30, 2017

Daniel15 commented May 7, 2017

bobmoff commented May 7, 2017 •

edited

Loading

tommedema commented Jan 23, 2019

Feature: Interactive update #1444

Feature: Interactive update #1444

Conversation

torifat commented Oct 25, 2016 • edited by cpojer Loading

cpojer commented Oct 26, 2016

Choose a reason for hiding this comment

torifat Oct 26, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Daniel15 commented Oct 26, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sebmck commented Nov 11, 2016

AlicanC commented Nov 11, 2016

sebmck commented Nov 11, 2016

torifat commented Nov 11, 2016

ccorcos commented Nov 15, 2016

Jessidhia commented Nov 16, 2016

bobmoff commented Apr 30, 2017

Daniel15 commented May 7, 2017

bobmoff commented May 7, 2017 • edited Loading

tommedema commented Jan 23, 2019

torifat commented Oct 25, 2016 •

edited by cpojer

Loading

torifat Oct 26, 2016 •

edited

Loading

bobmoff commented May 7, 2017 •

edited

Loading