Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty updates #98

Open
davidbrochart opened this issue Nov 29, 2022 · 0 comments · May be fixed by #104
Open

Empty updates #98

davidbrochart opened this issue Nov 29, 2022 · 0 comments · May be fixed by #104

Comments

@davidbrochart
Copy link
Collaborator

@Waidhoferj There is this code in your drawing example:

ypy/examples/drawing/client.py

Lines 28 to 31 in 792dc96

# Sometimes transactions don't write, which means updates are empty.
# We only care about updates with meaningful mutations.
if update != b'\x00\x00':
self.send_q.put_nowait(update)

Why are empty updates emitted? This creates issues here and there.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Filter Empty Updates from YDoc.observe_after_transaction Waidhoferj/ypy
1 participant
@davidbrochart