#1742 Improved the error reporting when the DefaultTestCaseDescriptorProvider fails. #3067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iptorProvider fails.
|
I'm going to leave this PR open, if you don't mind, because I'm not ready to evaluate it since I'm not sure there will be another v2 release. I'm not necessarily convinced that skipping is the right behavior here, and I'd also like to understand how a test case showed up with non-serializable data in the first place this far down the pipeline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
UniqueIDin theDefaultTestCaseDescriptorProvidercaused an exception when there were test method arguments that could not be serialized. The exception was silently dropped. This PR tries to improve error reporting in this case.This PR targets
v2because the same bug does not happen in v3 (the exception happens earlier and the fallback is theory enumeration during execution).Fixes #1742