Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added recommendation to use nameof #3062

Merged
merged 1 commit into from
Nov 18, 2024
Merged

added recommendation to use nameof #3062

merged 1 commit into from
Nov 18, 2024

Conversation

hpatel292-seneca
Copy link
Contributor

This fixes #2991

Change History

  • MemberDataAttribute: Updated XML documentation for the memberName parameter to recommend using the nameof operator for compile-time safety.
  • SkipWhen: Updated XML documentation to suggest the use of nameof for referencing public static properties to ensure safer and more maintainable code.
  • SkipUnless: Added a recommendation in the XML documentation to use the nameof operator when referencing public static properties, promoting best practices.

@hpatel292-seneca
Copy link
Contributor Author

@dotnet-policy-service agree

@bradwilson bradwilson merged commit c87ac93 into xunit:main Nov 18, 2024
2 checks passed
@bradwilson
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an analyzer which recommends nameof usage
2 participants
@hpatel292-seneca @bradwilson