Normalisation simplification (#3672) + giving all tables a schema #3675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…table-name format is consistently `schema/table` xtdb#3672
3 tasks
jarohen
added a commit
to jarohen/xtdb
that referenced
this pull request
Sep 6, 2024
jarohen
added a commit
to jarohen/xtdb
that referenced
this pull request
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Yes, I know, two big changes in one PR... 🙊)
When we did #3407, we left the on-disk names for
_idetc asxt$id, for ease of migration (it made it a non-breaking change) - but this caused a lot of mapping complexity in code.This PR propagates that rename onto both the tx-log and obj-store - as such, it's a breaking change for both, so users will be required to start their XT2 nodes afresh (i.e. clear tx-log and object-store). We're currently assuming, given XT2 is still 'early access', that this is acceptable - if this causes a problem for you, please do get in touch and we'll arrange a migration path.
The secondary change is related to table schemas - currently, we store most tables without a schema (with the exception of information_schema, pg_catalog etc). While we have a breaking tx-log and obj-store change going through, I've additionally taken the opportunity to ensure that all table-names contain a schema name (defaulting to
public, like Postgres). This is added as soon as possible (before it's written to the tx-log), which removes a fair bit of mapping/default handling within the rest of the codebase.There'll likely be one more change as part of #3672 - removing any mention/hint of normalisation from the non-Clojure APIs.