Skip to content

Conversation

@sadeghbarati
Copy link
Contributor

@sadeghbarati sadeghbarati commented Jan 23, 2024

This PR doesn't fix the freezing issue but fixes injecting CSS issue and improves SSR

Since we now injecting the CSS into the bundle what is should we put in package.json sideEffects field?

localhost_3000.-.Google.Chrome.2024-01-24.00-05-34.mp4

@vercel
Copy link

vercel bot commented Jan 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vue-sonner ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2024 8:49pm

Copy link
Owner

@xiaoluoboding xiaoluoboding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaoluoboding xiaoluoboding merged commit bcd36bd into xiaoluoboding:main Jan 24, 2024
@sadeghbarati sadeghbarati deleted the feat/inject-css branch January 24, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants