Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve workflow #57

Merged
merged 14 commits into from
Mar 15, 2022
Merged

Improve workflow #57

merged 14 commits into from
Mar 15, 2022

Conversation

nwlandry
Copy link
Collaborator

  • Updated the CONTRIBUTING.md file to match current workflow
  • Added a CHANGELOG file
  • Added isort as a dependency in the developer.txt requirements file

@nwlandry
Copy link
Collaborator Author

I attempted to add a notebook check with https://github.com/marketplace/actions/run-notebook, but it was ultimately unsuccessful.

@nwlandry nwlandry requested review from maximelucas and leotrs March 14, 2022 17:45
maximelucas
maximelucas approved these changes Mar 14, 2022
View reviewed changes
Copy link
Collaborator

@maximelucas maximelucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks Nicho!

@nwlandry nwlandry linked an issue Mar 14, 2022 that may be closed by this pull request
Import statements not sorted #55
Closed
leotrs
leotrs reviewed Mar 15, 2022
View reviewed changes
Copy link
Collaborator

@leotrs leotrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a single suggestion - I think that some of the steps that we (and other people familiar with developing/contributing to OSS projects) find useful or necessary may be problematic for first-time contributors.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@leotrs leotrs self-requested a review March 15, 2022 07:18
@nwlandry nwlandry merged commit 9e0ab65 into main Mar 15, 2022
@nwlandry nwlandry deleted the improve_workflow branch March 15, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximelucas maximelucas maximelucas approved these changes

@leotrs leotrs leotrs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import statements not sorted
3 participants
@nwlandry @leotrs @maximelucas