Set proposed drop index in wxGTK wxDataViewCtrl#25358
Closed
vadz wants to merge 1 commit intowxWidgets:masterfrom
Closed
Set proposed drop index in wxGTK wxDataViewCtrl#25358vadz wants to merge 1 commit intowxWidgets:masterfrom
vadz wants to merge 1 commit intowxWidgets:masterfrom
Conversation
Use "drag-data-received" signal instead of GtkTreeDragDestIface vfunc to be notified about drops on GtkTreeView, as the signal provides more information, notably the exact position of the drop and not just the nearest item to it, which allows to provide the proposed drop index in wxGTK too. Closes wxWidgets#2240. Co-authored-by: Vadim Zeitlin <[email protected]>
paulcor
approved these changes
May 2, 2025
vadz
added a commit
that referenced
this pull request
May 6, 2025
Use "drag-data-received" signal instead of GtkTreeDragDestIface vfunc to be notified about drops on GtkTreeView, as the signal provides more information, notably the exact position of the drop and not just the nearest item to it, which allows to provide the proposed drop index in wxGTK too. See #25358. Closes #2240. Co-authored-by: Vadim Zeitlin <[email protected]>
Contributor
Author
|
Merged in the commit above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use "drag-data-received" signal instead of GtkTreeDragDestIface vfunc to be notified about drops on GtkTreeView, as the signal provides more information, notably the exact position of the drop and not just the nearest item to it, which allows to provide the proposed drop index in wxGTK too.
Closes #2240.