Ensure that we include built-in 3rd party libraries headers#25352
Closed
vadz wants to merge 1 commit intowxWidgets:masterfrom
Closed
Ensure that we include built-in 3rd party libraries headers#25352vadz wants to merge 1 commit intowxWidgets:masterfrom
vadz wants to merge 1 commit intowxWidgets:masterfrom
Conversation
vadz
force-pushed
the
builtin-zlib
branch
2 times, most recently
from
7985b73 to
50d6ab5
Compare
Use template_append when using 3rd party library template to ensure that the include directories defined in the <lib> using this template appear first in the compiler command line, so that the correct headers get included even when the system libraries are also available. Note that this required refactoring the old 3rdparty_lib template into the base 3rdparty_lib_base and new 3rdparty_lib_u, as appending the old template to wxregex lib overwrote libname defined in the latter otherwise. Closes wxWidgets#25350.
vadz
added a commit
that referenced
this pull request
May 20, 2025
Use template_append when using 3rd party library template to ensure that the include directories defined in the <lib> using this template appear first in the compiler command line, so that the correct headers get included even when the system libraries are also available. Note that this required refactoring the old 3rdparty_lib template into the base 3rdparty_lib_base and new 3rdparty_lib_u, as appending the old template to wxregex lib overwrote libname defined in the latter otherwise. Closes #25350. See #25352.
Contributor
Author
|
Merged in the commit above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move -I options for built-in 3rd party libraries forward in the compiler command line to ensure that they're getting included even when the system libraries are also available.
Closes #25350.