Update wxrc.cpp. Use 7z when zip is not available#24782
Closed
CaoJunyu wants to merge 1 commit intowxWidgets:masterfrom
CaoJunyu:patch-1
Closed
Update wxrc.cpp. Use 7z when zip is not available#24782CaoJunyu wants to merge 1 commit intowxWidgets:masterfrom CaoJunyu:patch-1
CaoJunyu wants to merge 1 commit intowxWidgets:masterfrom
CaoJunyu:patch-1
Conversation
Use 7z when zip is not available.
Contributor
|
Thanks, using 7z as a fallback looks like a good idea, but wouldn't it even better to provide an option like |
vadz
added
the
work needed
Contributor
|
Sorry, but I don't want to apply this in the current state as it would introduce behaviour that we'd have to remain compatible with in the future and I'd rather not do this. If you can add the option, or propose some other change that would avoid this "auto detection", or at least explicitly enable it (e.g. |
Contributor
|
I'd still welcome a PR adding support for 7z but this can't be applied in the current state, so closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use 7z when zip is not available.