Improve wxValidators (3rd attempt)#24282
Draft
AliKet wants to merge 4 commits intowxWidgets:masterfrom
Draft
Conversation
added 2 commits
February 4, 2024 14:46
No real changes, just a refactoring to reduce code duplication between wxTextValidator and wxNumValidator.
By moving the OnPaste() handler to the wxTextEntryValidator base class and check whether the text can be pasted or not in the added CanPaste() function.
added 2 commits
February 4, 2024 22:41
This class uses wxRegEx to validate input strings in a text-like controls. Deriving from wxTextValidator is about making the regular expression a little shorter, understandable and powerful at the same time. Do not use any of the wxTextValidator wxFILTER_XXX styles other than wxFILTER_NONE, if the validator should only validate against the regular expression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's also nice to see these features implemented in
wxWidgets:wxRegexValidatorfor regular expression validations.wxValidators generate events to report validation failure/success. Or...wxValidatorProxyand let users customize validation behaviours:wxRichToolTipto show error messages instead of the default message box.wxEVT_TEXTevent while thewxDialog/wxPanelis initialized due to callingSetValue()in the process of transferring data to window (TransferToWindow())wxValidatorProxymight look like this:Thanks for any other ideas!