BUG: Compare strings for equality, not identity.

Strings in Python are usually interned (https://en.wikipedia.org/wiki/String_interning) but not always, so comparing identity can fail.
wwwslinger · Oct 30, 2013 · 1564765 · 1564765
1 parent 30eb78d
commit 1564765
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/sklearn/manifold/mds.py b/sklearn/manifold/mds.py
@@ -380,9 +380,9 @@ def fit_transform(self, X, init=None, y=None):
                           "dissimilarity matrix, set "
                           "``dissimilarity=precomputed``.")
 
-        if self.dissimilarity is "precomputed":
+        if self.dissimilarity == "precomputed":
             self.dissimilarity_matrix_ = X
-        elif self.dissimilarity is "euclidean":
+        elif self.dissimilarity == "euclidean":
             self.dissimilarity_matrix_ = euclidean_distances(X)
         else:
             raise ValueError("Proximity must be 'precomputed' or 'euclidean'."