Enable using login modifier with only partial path #531
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the login modifier requires passing the full
login-page
URL in the properties.Motivation and Context
Passing full URL to the login page is sometimes difficult, especially when a single suite is reused among multiple domains.
This PR enables running
login
modifier with only part of the login page, and the full URL is built usingdomain
(the same logic asurl
works).Upgrade notes (if appropriate)
This feature is backward compatible. Proper updates were made in the wiki docs.
The logic behind the change is:
login-page
starts withhttp
prefix, then the old logic is triggered (full login page URL)login-page
is treated as a path, anddomain
is added in the front (see unit tests for details).Types of changes
Checklist:
I hereby agree to the terms of the AET Contributor License Agreement.