Bugfix/Claner removing too many artifacts after timeout #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 7, 2019 16:01
tkaik
approved these changes
Mar 7, 2019
plutasnyy
approved these changes
Mar 8, 2019
malaskowski
approved these changes
Mar 11, 2019
tkaik
reviewed
Mar 11, 2019
CHANGELOG.md
Outdated
| @@ -22,6 +22,7 @@ All notable changes to AET will be documented in this file. | |||
| - [PR-413](https://github.com/Cognifide/aet/pull/413) Added ability to show full page source when there has been no difference discovered ([#369](https://github.com/Cognifide/aet/issues/369)) | |||
|
|
|||
| - [PR-463](https://github.com/Cognifide/aet/pull/463) Removed dependency to Joda time library | |||
| - [PR-490](https://github.com/Cognifide/aet/pull/490) Bugfix/Claner removing to many artifacts | |||
There was a problem hiding this comment.
Could you provide some more descriptive text here about what has changed? :) (e.g. timeout handling)
wblachowski
changed the title
added 2 commits
March 12, 2019 08:04
…-artifacts' into bugfix/cleaner-removing-too-many-artifacts # Conflicts: # CHANGELOG.md
wblachowski
changed the title
|
@wblachowski good job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed cleaner bug resulting in removing too many artifacts from database after timeout.
Description
Added discarding cleaner processing in case of aggregating task resulting in timeout.
Aggregating task outputs a list of referenced artifacts. Cleaner then removes all artifacts not present in the list. In case of timeout occurring, incomplete list of artifacts is passed further and as a result too many artifacts are removed from db.
Types of changes
Checklist:
I hereby agree to the terms of the AET Contributor License Agreement.