Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSGI-configurable chrome options #378

Merged
merged 2 commits into from
Oct 4, 2018
Merged

Conversation

tkaik
Copy link
Contributor

@tkaik tkaik commented Oct 4, 2018

Description

Chrome options (i.e. chrome run arguments) can now be configured in OSGi (ChromeWebDriverFactory component).

Motivation and Context

Using different sets of chrome options may help us to achieve screenshot consistency (e.g. by hiding scrollbars) or solve different stability/timeout issues when running Selenium Grid node with Chromedriver - e.g. see this stackoverflow thread as an example: https://stackoverflow.com/a/52340526 . OSGI configuration will enable us to easily change the chrome options when e.g. upgrading to newer chromedriver version will require it.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

I hereby agree to the terms of the AET Contributor License Agreement.

@tkaik tkaik requested review from malaskowski and plutasnyy October 4, 2018 13:26
Copy link
Contributor

@malaskowski malaskowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remember to update changelog as usual :)

@tkaik tkaik merged commit 4434173 into master Oct 4, 2018
@tkaik tkaik deleted the feature/configurable-chrome-options branch October 4, 2018 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants