This repository has been archived by the owner on Oct 16, 2024. It is now read-only.
Use .html() instead of .text() for play/pauseText #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can still stye everything with CSS, but this makes it a bit more flexxible, IMO. See Issue woocommerce#211.
|
Thanks for this, and your other pull requests, @dominic-p . Please keep them coming (on the "develop" branch), as you spot possible improvements or bugs that you've found solutions for. We're always keen to review pull requests, and will review these that you've submitted in our next sprint. If they're not all included in FlexSlider 2.2.0's release, they'll be inspected there-after in the follow-up releases. :) |
|
Thanks @dominic-p. I've merged this manually into the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can still style everything with CSS, but this makes it a bit more flexible, IMO. See Issue #211.