created about page for missing persons #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR contains some conflicts, would you please resolve them first. |
|
Is anyone reviewing this? |
It has some conflicts but would also need a copy review. |
iluyimbazi
reviewed
Jul 25, 2024
There was a problem hiding this comment.
I have ad a look in this PR and would like to make a few comments.
- The about page seems alright to me though the path to css needs to be changed to the one used on the live site.
- The dev wanted to add a top nav bar item for the About page, which I believe would improve accessibility of the site. I think this would be better if it were in a different nav bar, not to the existing one. may be do one with the Analytics, About and may be a con tact page. (Just thinking aloud)
- In the css file on line 16 there's a conflict but I think this would not be an issue if we use the same css we used on the main site, and ignore the one in this PR.
Overall, I would pass the About.html page, then incorporate a top nav bar to ease accessibility. For example having the analytics link at the top would be so helpful other than waiting to scroll to the bottom where it is now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.