Fix unstable WRITE when first write fails to open file #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marcharding Do you think you will merge this quickly and release a new version of winnfsd and vagrant-plugin ? |
|
I'll take a look later |
|
Hey looks good, thanks for fixing this. I'll try and push a new vagrant plugin today or tomorrow. |
|
hm, after a while the whole application freezes, this did not happen before while the initial tests and the appveyor build looks ok, something is not quite right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If something goes wrong on unstable
WRITEwhen opening the file (Access Denied because it's flagged read-only on server side fo example), a NULL entry is still stored inunstableStorageFile. This cause any futureWRITEcalls to the same file to always fail, becauseCOMMITmay not be invoked by the client.This PR fix this issue by storing file pointer in
unstableStorageFileonly if not NULL.