Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a consistent set of events that defines user activation #3849

Closed
mustaqahmed opened this issue Jul 24, 2018 · 10 comments
Closed

Need a consistent set of events that defines user activation #3849

mustaqahmed opened this issue Jul 24, 2018 · 10 comments

Comments

@mustaqahmed
Copy link
Contributor

This is related to #1903, where we are working on a user activation model. Here I am isolating the discussion on "events that should trigger a user activation" because this looks like a parallel work that can go ahead with or without the model question.

Current Activation section mentions (among other things) a list of activation triggering events. Unfortunately the list doesn't represent the reality. A recent catalog of activation-triggering events in Chrome, Edge, Firefox and Safari shows the big inconsistencies we have today, sometimes even between desktop and mobile versions of the same browser.

We need to fix this.

One challenging point is the possibility that the set of events could be API-specific!

@mustaqahmed
Copy link
Contributor Author

Chromium bug to track this: https://crbug.com/826293

@RByers
Copy link

RByers commented Oct 22, 2018

FWIW, I'm convinced by the argument here that in addition to a standardized list of events, we should have some single API to be informed of when frame has been activated (to prevent developers from having to maintain a hard-coded list of events, etc.).

In particular, the use case of starting the background music for a game is a good one - it's reasonable to want to do that as soon as the user has indicated any interaction, without necessarily caring what exact form that interaction comes in (eg. launching a PWA, or pressing a gamepad button which fires no dom events at all).

@RByers
Copy link

RByers commented Oct 23, 2018

Sorry, I missed @mustaqahmed's response in the WICG thread on this. Let's discuss this particular issue there in the WICG and come back here with any concrete proposal.

@domenic
Copy link
Member

domenic commented Sep 21, 2021

This interop problem remains. I recently wrote some web platform tests that assumed pressing keys (using testdriver) was an activation-triggering event, but that was not correct according to the spec, even though it was true in Chrome.

#6818 by @marcoscaceres is related; he is trying to add keypress and keyup, which at least according to @mustaqahmed's OP is a pretty complicated situation across browsers.

For keyboard events in particular, there is a big question as to what should count. E.g. in WICG/close-watcher#7 (comment) we are discussing whether the Esc key should count as user activation. Consider a user who visits a page, and all they do is press Esc; should that let the page show popups or play unmuted video or enter fullscreen??

@mustaqahmed
Copy link
Contributor Author

mustaqahmed commented Sep 22, 2021

In Chrome, we stopped counting Esc key as a user activation to fix a security bug a while ago.

[Edit: fixed the link above!]

@mustaqahmed
Copy link
Contributor Author

Let's explore a way to fix the overall mess here. I am proposing to address the following three sub-problems independently, please let us know your thoughts on each of these (and possibly other) cases.

A. Drop all high-level events

This should be the easiest one I believe: the current list of events include "high-level" events like submit because before User Activation v2, the user activation from a mousedown/keydown was not usable in a submit event-handler. This is no longer the case now, so we can drop all of them.

B. Fine-tune low-level events

The list logically omits touchstart (because a swipe is not a user activation and we can't identify a swipe at touchstart). But why is mousedown also omitted? I vaguely remember Chrome facing compat problems when trying to remove mousedown activation. What about other browsers?

What other low-level events do we need to consider? What about pointerdown?

C. Keyboard event trigger should be key-specific

It seems we reached the consensus that Esc key shouldn't activate the page (right?). Similarly, both Chrome (bug) and Firefox (bug) want to make browser hotkeys like ctrl-W or alt-LeftArrow non-activating. Which other keys fall in the same category? Should del and backspace keys activate or not?


To test your favorite browser's behavior, you can try (or tweak) the "control case" in this repro.

@annevk
Copy link
Member

annevk commented Oct 12, 2021

Overall that sounds reasonable to me. Probably any kind of browser accesskey you wouldn't want to count as activation? E.g., command+tab shouldn't result in a popup, it should result in a new browser tab.

cc @EdgarChen @johannhof

@domenic
Copy link
Member

domenic commented Oct 12, 2021

Agreed, that plan sounds great to me.

@eric-carlson
Copy link

B. Fine-tune low-level events

The list logically omits touchstart (because a swipe is not a user activation and we can't identify a swipe at touchstart). But why is mousedown also omitted? I vaguely remember Chrome facing compat problems when trying to remove mousedown activation. What about other browsers?

We also found compatibility problems when we tried to remove mousedown activation from WebKit.

Apple's WebKit port also includes touchstart activation, but only for media playback. We also tried to remove this at one point, but there were too many compatibility problems.

@mustaqahmed
Copy link
Contributor Author

I just sent out PR #7248, please take a look.

This PR addressed A, B and most part of C in my plan above. I realized that my original plan (to independently fix the sub-problems) won't work because removing click (for sub-problem A) would leave a gaping hole around keyboard activation!

@domenic domenic closed this as completed in 56071d6 Nov 1, 2021
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Nov 5, 2021
Related to HTML issue: whatwg/html#3849

Also fix double-activation in Chrome's gesture tap.

Bug: 826293, 1265587
Change-Id: I3bc3bcbcfeda242512fb777a1c8881c475fed5fc
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Nov 10, 2021
Related to HTML issue: whatwg/html#3849

Also fix double-activation in Chrome's gesture tap.

Bug: 826293, 1265587
Change-Id: I3bc3bcbcfeda242512fb777a1c8881c475fed5fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3254213
Reviewed-by: Robert Flack <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Mustaq Ahmed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#940118}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Nov 10, 2021
Related to HTML issue: whatwg/html#3849

Also fix double-activation in Chrome's gesture tap.

Bug: 826293, 1265587
Change-Id: I3bc3bcbcfeda242512fb777a1c8881c475fed5fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3254213
Reviewed-by: Robert Flack <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Mustaq Ahmed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#940118}
blueboxd pushed a commit to blueboxd/chromium-legacy that referenced this issue Nov 10, 2021
Related to HTML issue: whatwg/html#3849

Also fix double-activation in Chrome's gesture tap.

Bug: 826293, 1265587
Change-Id: I3bc3bcbcfeda242512fb777a1c8881c475fed5fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3254213
Reviewed-by: Robert Flack <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Mustaq Ahmed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#940118}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Nov 11, 2021
This reverts commit 34b3146d8dfc1e44715703e4cf97779fc7c8688d.

Reason for revert: Suspected cause of crbug.com/1269035, will
verify before submitting.

Original change's description:
> Add a WPT for pointerevent user activation trigger.
>
> Related to HTML issue: whatwg/html#3849
>
> Also fix double-activation in Chrome's gesture tap.
>
> Bug: 826293, 1265587
> Change-Id: I3bc3bcbcfeda242512fb777a1c8881c475fed5fc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3254213
> Reviewed-by: Robert Flack <[email protected]>
> Reviewed-by: Avi Drissman <[email protected]>
> Commit-Queue: Mustaq Ahmed <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#940118}

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 826293, 1265587
Change-Id: I4bc041f2254c382c00ce3596d61742ba84c79660
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Nov 12, 2021
This reverts commit 34b3146d8dfc1e44715703e4cf97779fc7c8688d.

Reason for revert: Suspected cause of crbug.com/1269035, will
verify before submitting.

Original change's description:
> Add a WPT for pointerevent user activation trigger.
>
> Related to HTML issue: whatwg/html#3849
>
> Also fix double-activation in Chrome's gesture tap.
>
> Bug: 826293, 1265587
> Change-Id: I3bc3bcbcfeda242512fb777a1c8881c475fed5fc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3254213
> Reviewed-by: Robert Flack <[email protected]>
> Reviewed-by: Avi Drissman <[email protected]>
> Commit-Queue: Mustaq Ahmed <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#940118}

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 826293, 1265587
Change-Id: I4bc041f2254c382c00ce3596d61742ba84c79660
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3277061
Reviewed-by: Brian Sheedy <[email protected]>
Reviewed-by: Johann Koenig <[email protected]>
Commit-Queue: Brian Sheedy <[email protected]>
Commit-Queue: Johann Koenig <[email protected]>
Owners-Override: Johann Koenig <[email protected]>
Cr-Commit-Position: refs/heads/main@{#940996}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Nov 12, 2021
This reverts commit 34b3146d8dfc1e44715703e4cf97779fc7c8688d.

Reason for revert: Suspected cause of crbug.com/1269035, will
verify before submitting.

Original change's description:
> Add a WPT for pointerevent user activation trigger.
>
> Related to HTML issue: whatwg/html#3849
>
> Also fix double-activation in Chrome's gesture tap.
>
> Bug: 826293, 1265587
> Change-Id: I3bc3bcbcfeda242512fb777a1c8881c475fed5fc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3254213
> Reviewed-by: Robert Flack <[email protected]>
> Reviewed-by: Avi Drissman <[email protected]>
> Commit-Queue: Mustaq Ahmed <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#940118}

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 826293, 1265587
Change-Id: I4bc041f2254c382c00ce3596d61742ba84c79660
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3277061
Reviewed-by: Brian Sheedy <[email protected]>
Reviewed-by: Johann Koenig <[email protected]>
Commit-Queue: Brian Sheedy <[email protected]>
Commit-Queue: Johann Koenig <[email protected]>
Owners-Override: Johann Koenig <[email protected]>
Cr-Commit-Position: refs/heads/main@{#940996}
blueboxd pushed a commit to blueboxd/chromium-legacy that referenced this issue Nov 12, 2021
This reverts commit 34b3146.

Reason for revert: Suspected cause of crbug.com/1269035, will
verify before submitting.

Original change's description:
> Add a WPT for pointerevent user activation trigger.
>
> Related to HTML issue: whatwg/html#3849
>
> Also fix double-activation in Chrome's gesture tap.
>
> Bug: 826293, 1265587
> Change-Id: I3bc3bcbcfeda242512fb777a1c8881c475fed5fc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3254213
> Reviewed-by: Robert Flack <[email protected]>
> Reviewed-by: Avi Drissman <[email protected]>
> Commit-Queue: Mustaq Ahmed <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#940118}

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 826293, 1265587
Change-Id: I4bc041f2254c382c00ce3596d61742ba84c79660
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3277061
Reviewed-by: Brian Sheedy <[email protected]>
Reviewed-by: Johann Koenig <[email protected]>
Commit-Queue: Brian Sheedy <[email protected]>
Commit-Queue: Johann Koenig <[email protected]>
Owners-Override: Johann Koenig <[email protected]>
Cr-Commit-Position: refs/heads/main@{#940996}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Nov 15, 2021
Related to HTML issue: whatwg/html#3849

Bug: 826293
Change-Id: I9e4bc0df46df63e05dac64af32c1aab7cdabffe4
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Nov 15, 2021
…on trigger., a=testonly

Automatic update from web-platform-tests
Add a WPT for pointerevent user activation trigger.

Related to HTML issue: whatwg/html#3849

Also fix double-activation in Chrome's gesture tap.

Bug: 826293, 1265587
Change-Id: I3bc3bcbcfeda242512fb777a1c8881c475fed5fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3254213
Reviewed-by: Robert Flack <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Mustaq Ahmed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#940118}

--

wpt-commits: aa2fc4c2ddfac8b0870c0b075899478c9cabc0c2
wpt-pr: 31521
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Nov 15, 2021
…activation trigger.", a=testonly

Automatic update from web-platform-tests
Revert "Add a WPT for pointerevent user activation trigger."

This reverts commit 34b3146d8dfc1e44715703e4cf97779fc7c8688d.

Reason for revert: Suspected cause of crbug.com/1269035, will
verify before submitting.

Original change's description:
> Add a WPT for pointerevent user activation trigger.
>
> Related to HTML issue: whatwg/html#3849
>
> Also fix double-activation in Chrome's gesture tap.
>
> Bug: 826293, 1265587
> Change-Id: I3bc3bcbcfeda242512fb777a1c8881c475fed5fc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3254213
> Reviewed-by: Robert Flack <[email protected]>
> Reviewed-by: Avi Drissman <[email protected]>
> Commit-Queue: Mustaq Ahmed <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#940118}

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 826293, 1265587
Change-Id: I4bc041f2254c382c00ce3596d61742ba84c79660
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3277061
Reviewed-by: Brian Sheedy <[email protected]>
Reviewed-by: Johann Koenig <[email protected]>
Commit-Queue: Brian Sheedy <[email protected]>
Commit-Queue: Johann Koenig <[email protected]>
Owners-Override: Johann Koenig <[email protected]>
Cr-Commit-Position: refs/heads/main@{#940996}

--

wpt-commits: eca3a50a442ab21283638efbf1617492924f5fdd
wpt-pr: 31608
jamienicol pushed a commit to jamienicol/gecko that referenced this issue Nov 16, 2021
…on trigger., a=testonly

Automatic update from web-platform-tests
Add a WPT for pointerevent user activation trigger.

Related to HTML issue: whatwg/html#3849

Also fix double-activation in Chrome's gesture tap.

Bug: 826293, 1265587
Change-Id: I3bc3bcbcfeda242512fb777a1c8881c475fed5fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3254213
Reviewed-by: Robert Flack <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Mustaq Ahmed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#940118}

--

wpt-commits: aa2fc4c2ddfac8b0870c0b075899478c9cabc0c2
wpt-pr: 31521
jamienicol pushed a commit to jamienicol/gecko that referenced this issue Nov 16, 2021
…activation trigger.", a=testonly

Automatic update from web-platform-tests
Revert "Add a WPT for pointerevent user activation trigger."

This reverts commit 34b3146d8dfc1e44715703e4cf97779fc7c8688d.

Reason for revert: Suspected cause of crbug.com/1269035, will
verify before submitting.

Original change's description:
> Add a WPT for pointerevent user activation trigger.
>
> Related to HTML issue: whatwg/html#3849
>
> Also fix double-activation in Chrome's gesture tap.
>
> Bug: 826293, 1265587
> Change-Id: I3bc3bcbcfeda242512fb777a1c8881c475fed5fc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3254213
> Reviewed-by: Robert Flack <[email protected]>
> Reviewed-by: Avi Drissman <[email protected]>
> Commit-Queue: Mustaq Ahmed <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#940118}

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 826293, 1265587
Change-Id: I4bc041f2254c382c00ce3596d61742ba84c79660
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3277061
Reviewed-by: Brian Sheedy <[email protected]>
Reviewed-by: Johann Koenig <[email protected]>
Commit-Queue: Brian Sheedy <[email protected]>
Commit-Queue: Johann Koenig <[email protected]>
Owners-Override: Johann Koenig <[email protected]>
Cr-Commit-Position: refs/heads/main@{#940996}

--

wpt-commits: eca3a50a442ab21283638efbf1617492924f5fdd
wpt-pr: 31608
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Nov 17, 2021
Related to HTML issue: whatwg/html#3849

Bug: 826293
Change-Id: I9e4bc0df46df63e05dac64af32c1aab7cdabffe4
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Nov 17, 2021
Related to HTML issue: whatwg/html#3849

Bug: 826293
Change-Id: I9e4bc0df46df63e05dac64af32c1aab7cdabffe4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3282485
Commit-Queue: Mustaq Ahmed <[email protected]>
Reviewed-by: Robert Flack <[email protected]>
Cr-Commit-Position: refs/heads/main@{#942663}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Nov 17, 2021
Related to HTML issue: whatwg/html#3849

Bug: 826293
Change-Id: I9e4bc0df46df63e05dac64af32c1aab7cdabffe4
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Nov 17, 2021
Related to HTML issue: whatwg/html#3849

Bug: 826293
Change-Id: I9e4bc0df46df63e05dac64af32c1aab7cdabffe4
pull bot pushed a commit to FairyWorld/tool_chromium that referenced this issue Nov 17, 2021
Related to HTML issue: whatwg/html#3849

Bug: 826293
Change-Id: I9e4bc0df46df63e05dac64af32c1aab7cdabffe4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3282485
Commit-Queue: Mustaq Ahmed <[email protected]>
Reviewed-by: Robert Flack <[email protected]>
Cr-Commit-Position: refs/heads/main@{#942663}
Gabisampaio pushed a commit to Gabisampaio/wpt that referenced this issue Nov 18, 2021
Related to HTML issue: whatwg/html#3849

Also fix double-activation in Chrome's gesture tap.

Bug: 826293, 1265587
Change-Id: I3bc3bcbcfeda242512fb777a1c8881c475fed5fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3254213
Reviewed-by: Robert Flack <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Mustaq Ahmed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#940118}
Gabisampaio pushed a commit to Gabisampaio/wpt that referenced this issue Nov 18, 2021
This reverts commit 34b3146d8dfc1e44715703e4cf97779fc7c8688d.

Reason for revert: Suspected cause of crbug.com/1269035, will
verify before submitting.

Original change's description:
> Add a WPT for pointerevent user activation trigger.
>
> Related to HTML issue: whatwg/html#3849
>
> Also fix double-activation in Chrome's gesture tap.
>
> Bug: 826293, 1265587
> Change-Id: I3bc3bcbcfeda242512fb777a1c8881c475fed5fc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3254213
> Reviewed-by: Robert Flack <[email protected]>
> Reviewed-by: Avi Drissman <[email protected]>
> Commit-Queue: Mustaq Ahmed <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#940118}

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 826293, 1265587
Change-Id: I4bc041f2254c382c00ce3596d61742ba84c79660
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3277061
Reviewed-by: Brian Sheedy <[email protected]>
Reviewed-by: Johann Koenig <[email protected]>
Commit-Queue: Brian Sheedy <[email protected]>
Commit-Queue: Johann Koenig <[email protected]>
Owners-Override: Johann Koenig <[email protected]>
Cr-Commit-Position: refs/heads/main@{#940996}
Gabisampaio pushed a commit to Gabisampaio/wpt that referenced this issue Nov 18, 2021
Related to HTML issue: whatwg/html#3849

Bug: 826293
Change-Id: I9e4bc0df46df63e05dac64af32c1aab7cdabffe4
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Nov 30, 2021
…on trigger., a=testonly

Automatic update from web-platform-tests
Add a WPT for pointerevent user activation trigger.

Related to HTML issue: whatwg/html#3849

Bug: 826293
Change-Id: I9e4bc0df46df63e05dac64af32c1aab7cdabffe4

--

wpt-commits: 266273172093e63a85e72b184735342d5c298797
wpt-pr: 31632
jamienicol pushed a commit to jamienicol/gecko that referenced this issue Nov 30, 2021
…on trigger., a=testonly

Automatic update from web-platform-tests
Add a WPT for pointerevent user activation trigger.

Related to HTML issue: whatwg/html#3849

Bug: 826293
Change-Id: I9e4bc0df46df63e05dac64af32c1aab7cdabffe4

--

wpt-commits: 266273172093e63a85e72b184735342d5c298797
wpt-pr: 31632
dandclark pushed a commit to dandclark/html that referenced this issue Dec 4, 2021
* Remove all high-level events that follows a low-level event.
* Add missing low-level events that are known to be required.
* Add keyboard events, in a conditional manner.

Fixes whatwg#3849.
mfreed7 pushed a commit to mfreed7/html that referenced this issue Jun 3, 2022
* Remove all high-level events that follows a low-level event.
* Add missing low-level events that are known to be required.
* Add keyboard events, in a conditional manner.

Fixes whatwg#3849.
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this issue Oct 14, 2022
Related to HTML issue: whatwg/html#3849

Also fix double-activation in Chrome's gesture tap.

Bug: 826293, 1265587
Change-Id: I3bc3bcbcfeda242512fb777a1c8881c475fed5fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3254213
Reviewed-by: Robert Flack <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Mustaq Ahmed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#940118}
NOKEYCHECK=True
GitOrigin-RevId: 34b3146d8dfc1e44715703e4cf97779fc7c8688d
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this issue Oct 14, 2022
This reverts commit 34b3146d8dfc1e44715703e4cf97779fc7c8688d.

Reason for revert: Suspected cause of crbug.com/1269035, will
verify before submitting.

Original change's description:
> Add a WPT for pointerevent user activation trigger.
>
> Related to HTML issue: whatwg/html#3849
>
> Also fix double-activation in Chrome's gesture tap.
>
> Bug: 826293, 1265587
> Change-Id: I3bc3bcbcfeda242512fb777a1c8881c475fed5fc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3254213
> Reviewed-by: Robert Flack <[email protected]>
> Reviewed-by: Avi Drissman <[email protected]>
> Commit-Queue: Mustaq Ahmed <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#940118}

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 826293, 1265587
Change-Id: I4bc041f2254c382c00ce3596d61742ba84c79660
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3277061
Reviewed-by: Brian Sheedy <[email protected]>
Reviewed-by: Johann Koenig <[email protected]>
Commit-Queue: Brian Sheedy <[email protected]>
Commit-Queue: Johann Koenig <[email protected]>
Owners-Override: Johann Koenig <[email protected]>
Cr-Commit-Position: refs/heads/main@{#940996}
NOKEYCHECK=True
GitOrigin-RevId: 9872337b36442fa626dad89cee80f77fdd41fb30
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this issue Oct 14, 2022
Related to HTML issue: whatwg/html#3849

Bug: 826293
Change-Id: I9e4bc0df46df63e05dac64af32c1aab7cdabffe4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3282485
Commit-Queue: Mustaq Ahmed <[email protected]>
Reviewed-by: Robert Flack <[email protected]>
Cr-Commit-Position: refs/heads/main@{#942663}
NOKEYCHECK=True
GitOrigin-RevId: 5a60aab31ba136dae6cd61b0e48cb753929b1051
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

7 participants
@zcorpan @domenic @eric-carlson @RByers @annevk @mustaqahmed and others