-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Reorganize user guide #2050
Conversation
Good to tell people why they're doing things!
really minor update to align with newly selected brand colours
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There IS a quick way of collapsing the sidebar! I've disabled the feature that prevents that in d34512f, probably better this way for the reorg you've done. 👍
- Added some colour changes (moves things in-line with other colours selected for the website
- Fixed some ID links
- Slightly adjusted the language on the sign up page
Overall I like this a lot! I'm sort of surprised it didn't take as much re-writing as I had thought heh. Sign up page looks good!
I would like to move the content on the index page to a more complete "first crawl" guide, but I think we should do that later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Left a bunch of capitalization suggestions, along with a few questions
Co-authored-by: Emma Segal-Grossman <[email protected]>
Co-authored-by: Emma Segal-Grossman <[email protected]>
Co-authored-by: Tessa Walsh <[email protected]> Co-authored-by: Emma Segal-Grossman <[email protected]>
Branding! At last!
@@ -25,34 +25,50 @@ | |||
src: url('../assets/fonts/Inter-Italic.var.woff2') format('woff2'); | |||
font-feature-settings: "ss03"; | |||
} | |||
|
|||
@font-face { | |||
font-family: 'Konsole'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woohoo!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
heh, probably should have made this a separate PR... Sorry Sua 🙃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NBD looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few relatively minor grammatical changes and nits but overall this is fantastic! Excellent work :)
Co-authored-by: Tessa Walsh <[email protected]>
Remove number
Resolves #2041
Note: If this is ready to be merged before #2020 we'll need to comment out the org settings "Crawl Workflows" section.
Reorganizes user guide to be more solutions based. For the most part, I kept the content the same but moved sections into separate files.
New/overhauled pages:
Feel free to commit suggestions directly.