Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow org admins to update slug #1276

Merged
merged 8 commits into from
Oct 14, 2023
Merged

Allow org admins to update slug #1276

merged 8 commits into from
Oct 14, 2023

Conversation

SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Oct 11, 2023

Resolves #1259

Changes

Manual testing

  1. Log in as org admin and go to "Org Settings"
  2. Type in different org slug. Verify that help text updates with a valid slug.
  3. Save changes. Verify slug saves as expected

Screenshots

Page Image/video
Org Settings - General Screenshot 2023-10-11 at 4 55 04 PM

@SuaYoo SuaYoo marked this pull request as ready for review October 11, 2023 23:18
@SuaYoo SuaYoo requested review from ikreymer, Shrinks99 and tw4l October 11, 2023 23:19
@SuaYoo SuaYoo marked this pull request as draft October 11, 2023 23:31
@SuaYoo SuaYoo marked this pull request as ready for review October 11, 2023 23:57
Copy link
Member

@Shrinks99 Shrinks99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works! Thoughts on giving this a more user-facing name? We may want to use this ID outside of URLs in the future... Though not a big deal either way.

frontend/src/pages/org/settings.ts Outdated Show resolved Hide resolved
frontend/src/pages/org/settings.ts Outdated Show resolved Hide resolved
@ikreymer ikreymer merged commit 8466caf into main Oct 14, 2023
2 checks passed
@ikreymer ikreymer deleted the frontend-update-org-slug branch October 14, 2023 02:30
ikreymer pushed a commit that referenced this pull request Oct 16, 2023
Fast follower #1276

Updates label, info text, and preview text for org slug field to be more user-friendly
use 'Custom URL Identifier' and 'Custom your organization's web address for accessing Browsertrix Cloud'
---------
Co-authored-by: Ilya Kreymer <[email protected]>
Co-authored-by: Henry Wilkinson <[email protected]>
tw4l pushed a commit that referenced this pull request Oct 18, 2023
- Allows editing of org slugs (actual URL updates will be handled in
#1258.)
- Converts user input to slug using slugify
- Adds help text to org name and slug
- Renames tab from "information" to "general" settings
tw4l pushed a commit that referenced this pull request Oct 18, 2023
Fast follower #1276

Updates label, info text, and preview text for org slug field to be more user-friendly
use 'Custom URL Identifier' and 'Custom your organization's web address for accessing Browsertrix Cloud'
---------
Co-authored-by: Ilya Kreymer <[email protected]>
Co-authored-by: Henry Wilkinson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow org admins to change slug
3 participants