-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow org admins to update slug #1276
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shrinks99
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works! Thoughts on giving this a more user-facing name? We may want to use this ID outside of URLs in the future... Though not a big deal either way.
Co-authored-by: Henry Wilkinson <[email protected]>
ikreymer
pushed a commit
that referenced
this pull request
Oct 16, 2023
Fast follower #1276 Updates label, info text, and preview text for org slug field to be more user-friendly use 'Custom URL Identifier' and 'Custom your organization's web address for accessing Browsertrix Cloud' --------- Co-authored-by: Ilya Kreymer <[email protected]> Co-authored-by: Henry Wilkinson <[email protected]>
tw4l
pushed a commit
that referenced
this pull request
Oct 18, 2023
- Allows editing of org slugs (actual URL updates will be handled in #1258.) - Converts user input to slug using slugify - Adds help text to org name and slug - Renames tab from "information" to "general" settings
tw4l
pushed a commit
that referenced
this pull request
Oct 18, 2023
Fast follower #1276 Updates label, info text, and preview text for org slug field to be more user-friendly use 'Custom URL Identifier' and 'Custom your organization's web address for accessing Browsertrix Cloud' --------- Co-authored-by: Ilya Kreymer <[email protected]> Co-authored-by: Henry Wilkinson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1259
Changes
Manual testing
Screenshots