Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show storage values for each item type when no quota #1260

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Show storage values for each item type when no quota #1260

merged 2 commits into from
Oct 13, 2023

Conversation

SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Oct 10, 2023

Follow-up to #1188

Changes

Hides chart and shows size values for each Storage line when org has no quota. No changes to orgs with quota.

Screenshots

Page Image/video
Overview Screenshot 2023-10-10 at 12 07 25 PM

@SuaYoo SuaYoo requested a review from ikreymer October 10, 2023 19:10
@ikreymer
Copy link
Member

ikreymer commented Oct 11, 2023 •
edited
Loading

Nice! Only suggestion would be to make the number and text separate column so, for example, Uploads and Browser Profiles text align in the image above (if not too much time).

@SuaYoo
Copy link
Member Author

SuaYoo commented Oct 13, 2023

Only suggestion would be to make the number and text separate column so, for example, Uploads and Browser Profiles text align in the image above (if not too much time).

Tried a quick version to preview, I think it may look a bit odd when numbers are larger and unevenly distributed:
Screenshot 2023-10-12 at 7 58 51 PM

@ikreymer
Copy link
Member

Only suggestion would be to make the number and text separate column so, for example, Uploads and Browser Profiles text align in the image above (if not too much time).

Tried a quick version to preview, I think it may look a bit odd when numbers are larger and unevenly distributed: Screenshot 2023-10-12 at 7 58 51 PM

Yeah, that's a good point, I guess we'd have to style the numbers differently to make this look better, maybe not needed for now, can revisit later.

@ikreymer ikreymer merged commit 22fbf92 into main Oct 13, 2023
2 checks passed
@ikreymer ikreymer deleted the frontend-dashboard-no-quota-values branch October 13, 2023 21:31
tw4l pushed a commit that referenced this pull request Oct 18, 2023
@SuaYoo @tw4l
Show storage values for each item type when no quota (#1260)
51866a8 
Hides chart and shows size values for each Storage line when org has no
quota. No changes to orgs with quota. (Follow-up to #1188)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikreymer ikreymer ikreymer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SuaYoo @ikreymer