Storage Ops Refactor #1257
Merged
Storage Ops Refactor #1257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- create StorageOps class similar to other ops classes - init storages list in StorageOps, no longer require lookup up default storages via CrawlManager - convert all storage functions to members, add storageops to operator
crawls: just return empty list if not a crawl (eg. upload)
tw4l
reviewed
Oct 10, 2023
Member
There was a problem hiding this comment.
Thanks, this is good cleanup and a nice step toward having multiple configured storages!
Edit: After discussing offline, removing my other suggestions/comments here as I think they will be better handled all at once in a separate PR introducing replication.
tw4l
approved these changes
Oct 10, 2023
ikreymer
added a commit
that referenced
this pull request
Oct 11, 2023
- fix refactor typo - add type hints for all storageops apis
This was referenced Oct 11, 2023
ikreymer
added a commit
that referenced
this pull request
Oct 11, 2023
* storage ops: follow up to #1257: - fix refactor typo - add type hints for all storageops apis (add mypy_boto3_s3 and types_aiobotocore_s3 for type hints)
tw4l
pushed a commit
that referenced
this pull request
Oct 12, 2023
* storage ops: follow up to #1257: - fix refactor typo - add type hints for all storageops apis (add mypy_boto3_s3 and types_aiobotocore_s3 for type hints)
tw4l
pushed a commit
that referenced
this pull request
Oct 18, 2023
* storage ops: follow up to #1257: - fix refactor typo - add type hints for all storageops apis (add mypy_boto3_s3 and types_aiobotocore_s3 for type hints)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the storage API to be consistent with other ops classes: