Compute crawl execution time in operator #1256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename isNewCrash -> isNewExit, crashTime -> exitTime - keep track of exitCode - add execTime counter, increment when state has a 'finishedAt' and 'startedAt' state - ensure pods are complete before deleting
- set redis :canceled key to immediately cancel crawl - delete crawl pods to ensure pod exits immediately - in finalizer, don't wait for pods to complete - add currentTime in pod.status.running.startedAt times for all existing pods
ikreymer
force-pushed
the
issue-1776-execution-time-in-operator
branch
from
9ed49ed to
e56c49e
Compare
tw4l
approved these changes
Oct 9, 2023
Member
tw4l
left a comment
tw4l
left a comment
There was a problem hiding this comment.
Tested with cancelled cralls, sending SIGINTs to restart crawler pods, and scale at 1 and higher. Working well in all cases. Nice work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alterate fix for #1176, superseding #1218 and #1249
Computing the execution time entirely in the operator
terminated.state.finishedAtandterminated.state.startedAtto new crawljobexecTimecounter<current time>-running.state.startedAttime for each running pod, then deleting all running pods. The term interrupt combined with redis state should result in crawler pods exiting right away.running.state.startedAtin finalizer.