Make URLs in the settings viewer clickable, removes deeplinked titles #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- URLs open in a new tab - Does not do anything with the `Extra URLs in Scope` field which we currently render as a regex so I left that alone? Perhaps not ideal...
Our URL scheme has changed and these don't work anymore
Shrinks99
changed the title
SuaYoo
requested changes
Oct 13, 2023
|
Method removed! |
Shrinks99
changed the title
ikreymer
approved these changes
Oct 18, 2023
|
This looks good to go! Thanks @SuaYoo for previous review. It might be nice to add the links back in some day, but very low pri. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Extra URLs in Scopefield which we currently render as a regex so I left that alone?Screenshots
Workflow settings page before and after
Crawl Settings page before and after
Workflow settings review page
