Skip to content

Make URLs in the settings viewer clickable, removes deeplinked titles #1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ikreymer merged 7 commits into from
Oct 18, 2023
Merged

Make URLs in the settings viewer clickable, removes deeplinked titles #1247

ikreymer merged 7 commits into from
Oct 18, 2023

Conversation

@Shrinks99
Copy link
Contributor

@Shrinks99 Shrinks99 commented Oct 3, 2023

Changes

  • URLs on the config review pages are now links that open in a new tab
  • Does not do anything with the Extra URLs in Scope field which we currently render as a regex so I left that alone?
  • Hides the previously deep-linked but now broken config section rendering.
    • Possibly not ideal? @SuaYoo Should this code be removed outright?

Screenshots

Workflow settings page before and after
Screenshot 2023-10-03 at 5 43 53 PM
Screenshot 2023-10-03 at 5 44 03 PM

Crawl Settings page before and after
Screenshot 2023-10-03 at 5 44 45 PM
Screenshot 2023-10-03 at 5 44 53 PM

Workflow settings review page
Screenshot 2023-10-03 at 6 03 14 PM

@Shrinks99
Makes URLs in the settings viewer clickable
7e8841d 
- URLs open in a new tab
- Does not do anything with the `Extra URLs in Scope` field which we currently render as a regex so I left that alone?  Perhaps not ideal...
@Shrinks99
Comment out broken in-page-link copy buttons
cb3a097 
Our URL scheme has changed and these don't work anymore
@Shrinks99 Shrinks99 added the enhancement Requests a change to a feature label Oct 3, 2023
@Shrinks99 Shrinks99 added this to the DRAFT Release 2023.10 milestone Oct 3, 2023
@Shrinks99 Shrinks99 requested a review from SuaYoo October 3, 2023 22:03
@Shrinks99 Shrinks99 self-assigned this Oct 3, 2023
@Shrinks99 Shrinks99 changed the title Make URLs in the settings viewer clickable, Comment out Make URLs in the settings viewer clickable, Comment out deeplinks Oct 4, 2023
SuaYoo
SuaYoo requested changes Oct 13, 2023
View reviewed changes
@Shrinks99 Shrinks99 requested a review from SuaYoo October 16, 2023 21:05
@Shrinks99
Copy link
Contributor Author

Shrinks99 commented Oct 16, 2023

Method removed!

@Shrinks99 Shrinks99 requested a review from ikreymer October 16, 2023 21:06
@Shrinks99 Shrinks99 changed the title Make URLs in the settings viewer clickable, Comment out deeplinks Make URLs in the settings viewer clickable, removes deeplinked titles Oct 17, 2023
@ikreymer
Copy link
Member

ikreymer commented Oct 18, 2023

This looks good to go! Thanks @SuaYoo for previous review. It might be nice to add the links back in some day, but very low pri.

@ikreymer ikreymer merged commit 40da1f8 into main Oct 18, 2023
@ikreymer ikreymer deleted the frontend-crawl-settings-links branch October 18, 2023 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ikreymer ikreymer ikreymer approved these changes

@SuaYoo SuaYoo Awaiting requested review from SuaYoo

Assignees

@Shrinks99 Shrinks99

Labels

enhancement Requests a change to a feature

Projects

None yet

Milestone

Release 2023.10

Development

Successfully merging this pull request may close these issues.

4 participants

@Shrinks99 @ikreymer @SuaYoo