-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CODEOWNERS update #7350
CODEOWNERS update #7350
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: f9878e5 | Previous: 3687070 | Ratio |
---|---|---|---|
processingTx |
22952 ops/sec (±6.41% ) |
22856 ops/sec (±6.62% ) |
1.00 |
processingContractDeploy |
37672 ops/sec (±10.04% ) |
37573 ops/sec (±8.57% ) |
1.00 |
processingContractMethodSend |
15512 ops/sec (±8.31% ) |
15453 ops/sec (±7.92% ) |
1.00 |
processingContractMethodCall |
28189 ops/sec (±5.93% ) |
27091 ops/sec (±7.83% ) |
0.96 |
abiEncode |
44589 ops/sec (±6.99% ) |
42669 ops/sec (±7.08% ) |
0.96 |
abiDecode |
29827 ops/sec (±7.72% ) |
30350 ops/sec (±6.23% ) |
1.02 |
sign |
1521 ops/sec (±2.93% ) |
1520 ops/sec (±3.42% ) |
1.00 |
verify |
371 ops/sec (±0.83% ) |
362 ops/sec (±0.69% ) |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7350 +/- ##
=======================================
Coverage 94.50% 94.50%
=======================================
Files 217 217
Lines 8487 8487
Branches 2343 2343
=======================================
Hits 8021 8021
Misses 466 466
Flags with carried forward coverage won't be shown. Click here to find out more. |
Description
CODEOWNERS update
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.