Add Stationhead connector #4068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inverse
added
new-feature
inverse
reviewed
Aug 29, 2023
src/connectors/stationhead.ts
Outdated
| export {}; | ||
|
|
||
| Connector.useMediaSessionApi(); | ||
| Connector.playerSelector = '#root>div>div:nth-child(2)>div>div>div>div>div:nth-child(2)>div:nth-child(2)>div'; |
There was a problem hiding this comment.
Is there not any class or ID on the element to make this less brittle to changes?
Also please add a new line after :)
There was a problem hiding this comment.
The website only have generated class from library they use, when website have an update will regenerate the class.
Done add new line on end of file.
inverse
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you made
Stationhead now has web player. The web player can connect to apple music or spotify. With this connector user can scrobble when Stationhead connected to Apple Music or when lastfm not connected to spotify account.
The app url :
https://www.stationhead.com/ or https://app.stationhead.com/
Fix #2879
Additional context
Testing
Thank You