-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename generic-sensor as sensors to align with specname #9895
Conversation
@foolip, PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Please rename and merge, then we'll see about #9830.
interfaces/generic-sensor.idl
Outdated
@@ -1,25 +0,0 @@ | |||
[SecureContext, Exposed=Window] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than removing this, can you rename it? In case #9830 has no differences, that'll leave a clearer history behind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
If you want to rename https://github.com/w3c/web-platform-tests/tree/master/generic-sensor as well in this same PR, that'd be fine I think. |
Sure, I will do that. |
Build PASSEDStarted: 2018-03-07 07:10:55 Failing Jobs
View more information about this build on: |
LGTM |
@foolip, @lukebjerring, I revisit the introduction guide at http://web-platform-tests.org/introduction.html to confirm how to define directories.
So, we should use the shorname of publications under PTAL, I suppose this will affect the code in auto-sync tool. |
@foolip, @lukebjerring, friendly ping. |
Hmm, so the rename has already happened now. I didn't realize the TR name is different, that seems annoying, and certainly for the purposes of auto-updating IDL it's simpler to pick a name based on the URL we're getting the IDL from rather than where a snapshot might live. @jgraham @gsnedders what do you think about this? What should http://web-platform-tests.org/introduction.html#test-layout say, and should we do anything about cases that don't match what it says? My preference is the IDs in https://github.com/foolip/day-to-day/blob/gh-pages/specs.json, because I've picked my favorite ones across the board :) |
@foolip so I'm pretty sure it says the TR name because the TR name tends to be far more stable; I don't really have any strong preference but I'd rather not move things around too often. |
I guess I think that once something has a TR name, then the github.io name should never change, unless the TR name changes as well. I think there are a few more mismatched cases like this, but I'm not going to go looking for them and seek to unify. Unless someone notices, I guess leave this one as sensors? |
Another instance of Battery Status API:
IMO, an update for test suite directory will affect many referenced link in corresponding spec documentations(spec, wiki, WG charter). I'd prefer leave it as TR name. |
I'm happy to leave that one alone too. |
Which one? Battery Status API? |
A few more mismatched cases, but not all:
|
Yep, mediacapture-streams vs. mediacapture-main is a fun mismatch I've stumbled upon many times. @Honry, can you file an issue about documenting this, adding the policy label? If you have a suggested, you can just send a PR. Whatever "rule" we have, I think we still need to think critically about whether the names make sense. Just "manifest" for example isn't great, given that we also have tools/manifest/ and, well, the manifest. |
reflect to #9830