Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for GeolocationSensor.read() #9662

Merged
merged 2 commits into from
Mar 14, 2018
Merged

Add tests for GeolocationSensor.read() #9662

merged 2 commits into from
Mar 14, 2018

Conversation

Honry
Copy link
Contributor

@Honry Honry commented Feb 26, 2018 •
edited by wpt-pr-bot
Loading

covers:

  • verify sensor reading when call read() method
  • verify sensor reading when signal is set to null
  • throw AbortError when singal's abort flag is set
  • throw SecurityError when disabled by Feature Policy
  • AbortError takes priority when disabled by Feature Policy

@ghost
Copy link

ghost commented Feb 26, 2018 •
edited by ghost
Loading

Build PASSED

Started: 2018-02-26 05:02:09
Finished: 2018-02-26 05:09:25

View more information about this build on:

@Honry
Copy link
Contributor Author

Honry commented Feb 26, 2018

@anssiko, @pozdnyakov, @alexshalamov, PTAL. And please let me know if there's coverage gap. Thanks!

@Honry
Add tests for GeolocationSensor.read()
0d00a84 
covers:
  - verify sensor reading when call read() method
  - verify sensor reading when signal is set to null
  - throw AbortError when singal's abort flag is set
  - throw SecurityError when disabled by Feature Policy
  - AbortError takes priority when disabled by Feature Policy
@Honry
Prettier code
4f498cf
@anssiko
Copy link
Member

anssiko commented Feb 27, 2018

PTAL @kenchris

@Honry
Copy link
Contributor Author

Honry commented Mar 7, 2018

@kenchris, friendly ping. :)

@anssiko
Copy link
Member

anssiko commented Mar 13, 2018

@Honry I think this can be landed.

@Honry Honry merged commit 772ed22 into web-platform-tests:master Mar 14, 2018
@Honry Honry deleted the geo-read branch March 14, 2018 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anssiko anssiko anssiko approved these changes

@pozdnyakov pozdnyakov Awaiting requested review from pozdnyakov

@alexshalamov alexshalamov Awaiting requested review from alexshalamov

Assignees
No one assigned
Labels
geolocation-sensor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Honry @anssiko @wpt-pr-bot