Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"sub" suffix should be used in where server env is defined #8562

Merged
merged 1 commit into from
Dec 6, 2017
Merged

"sub" suffix should be used in where server env is defined #8562

merged 1 commit into from
Dec 6, 2017

Conversation

Honry
Copy link
Contributor

@Honry Honry commented Dec 5, 2017 •
edited by wpt-pr-bot
Loading

Fix #8550

@Honry
Copy link
Contributor Author

Honry commented Dec 5, 2017

@pozdnyakov, PTAL.

@ghost
Copy link

ghost commented Dec 5, 2017 •
edited by ghost
Loading

Build PASSED

Started: 2017-12-05 07:39:22
Finished: 2017-12-05 08:05:20

Failing Jobs

  • MicrosoftEdge:14.14393

View more information about this build on:

pozdnyakov
pozdnyakov approved these changes Dec 5, 2017
View reviewed changes
Copy link
Contributor

@pozdnyakov pozdnyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@Honry
Copy link
Contributor Author

Honry commented Dec 6, 2017

Thanks @pozdnyakov, merging it.

@Honry Honry merged commit 489f48e into web-platform-tests:master Dec 6, 2017
@Honry Honry deleted the fix-8550 branch December 6, 2017 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pozdnyakov pozdnyakov pozdnyakov approved these changes

@alexshalamov alexshalamov Awaiting requested review from alexshalamov

@anssiko anssiko Awaiting requested review from anssiko

@dontcallmedom dontcallmedom Awaiting requested review from dontcallmedom

@riju riju Awaiting requested review from riju

@Volker-E Volker-E Awaiting requested review from Volker-E

@zqzhang zqzhang Awaiting requested review from zqzhang

Assignees
No one assigned
Labels
accelerometer ambient-light generic-sensor geolocation-sensor gyroscope magnetometer orientation-sensor wg-dap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Honry @pozdnyakov @wpt-pr-bot