Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature policy tests for generic sensors #8491

Merged
merged 1 commit into from
Nov 30, 2017
Merged

Add feature policy tests for generic sensors #8491

merged 1 commit into from
Nov 30, 2017

Conversation

Honry
Copy link
Contributor

@Honry Honry commented Nov 29, 2017 •
edited by wpt-pr-bot
Loading

Fix #8417

@Honry
Copy link
Contributor Author

Honry commented Nov 29, 2017

@alexshalamov, @pozdnyakov, PTAL.

pozdnyakov
pozdnyakov approved these changes Nov 29, 2017
View reviewed changes
Copy link
Contributor

@pozdnyakov pozdnyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@ghost
Copy link

ghost commented Nov 29, 2017 •
edited by ghost
Loading

Build PASSED

Started: 2017-11-29 08:33:36
Finished: 2017-11-29 09:03:46

Failing Jobs

  • MicrosoftEdge:14.14393

View more information about this build on:

@pozdnyakov pozdnyakov mentioned this pull request Nov 29, 2017
Merged
@Honry
Copy link
Contributor Author

Honry commented Nov 30, 2017

Thanks @anssiko and @pozdnyakov, merging it.

@Honry Honry merged commit c187a8f into web-platform-tests:master Nov 30, 2017
@Honry Honry deleted the sensor-fp branch November 30, 2017 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pozdnyakov pozdnyakov pozdnyakov approved these changes

@anssiko anssiko anssiko approved these changes

@alexshalamov alexshalamov Awaiting requested review from alexshalamov

@clelland clelland Awaiting requested review from clelland

@dontcallmedom dontcallmedom Awaiting requested review from dontcallmedom

@riju riju Awaiting requested review from riju

@Volker-E Volker-E Awaiting requested review from Volker-E

@zqzhang zqzhang Awaiting requested review from zqzhang

Assignees
No one assigned
Labels
accelerometer ambient-light feature-policy generic-sensor geolocation-sensor gyroscope magnetometer orientation-sensor wg-dap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Honry @anssiko @pozdnyakov @wpt-pr-bot