[pip] preferInitialWindowPlacement #47178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `preferInitialWindowPlacement` to DocumentPictureInPictureOptions to provide a hint to the UA that the bounds of any previously opened pip window probably shouldn't be re-used. See WICG/document-picture-in-picture#119 and https://chromestatus.com/feature/5183881532932096 for more details. Change-Id: I3c3cf468046f4e08cbedbde93532e4b34e12a29a Bug: 312495380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5608743 Reviewed-by: Philip Rogers <[email protected]> Commit-Queue: Frank Liberato <[email protected]> Reviewed-by: Tommy Steimel <[email protected]> Auto-Submit: Frank Liberato <[email protected]> Cr-Commit-Position: refs/heads/main@{#1328934}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5608743
branch
from
b05c599 to
ed9984f
Compare
wpt-pr-bot
approved these changes
Jul 17, 2024
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
preferInitialWindowPlacementto DocumentPictureInPictureOptionsto provide a hint to the UA that the bounds of any previously opened
pip window probably shouldn't be re-used.
See WICG/document-picture-in-picture#119 and
https://chromestatus.com/feature/5183881532932096 for more details.
Change-Id: I3c3cf468046f4e08cbedbde93532e4b34e12a29a
Bug: 312495380
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5608743
Reviewed-by: Philip Rogers <[email protected]>
Commit-Queue: Frank Liberato <[email protected]>
Reviewed-by: Tommy Steimel <[email protected]>
Auto-Submit: Frank Liberato <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1328934}