Skip to content

Correct @page properties for pages caused by OOFs. #46090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2024

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented May 6, 2024

When we create additional pages to place out-of-flow positioned
elements, pass the correct page index, so that :first / :left / :right
selectors are treated correctly.

Change-Id: Id289b0d026148518796898ea3d5da8c9a5d48a2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5513509
Commit-Queue: Morten Stenshorne <[email protected]>
Reviewed-by: Alison Maher <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1297040}

When we create additional pages to place out-of-flow positioned
elements, pass the correct page index, so that :first / :left / :right
selectors are treated correctly.

Change-Id: Id289b0d026148518796898ea3d5da8c9a5d48a2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5513509
Commit-Queue: Morten Stenshorne <[email protected]>
Reviewed-by: Alison Maher <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1297040}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@dev-ansung
Copy link
Contributor

WPT Command: python3 ./wpt run --channel=nightly --verify --verify-no-chaos-mode --verify-repeat-loop=0 --verify-repeat-restart=10 --github-checks-text-file=/home/test/artifacts/checkrun.md --affected base_head --log-mach-level=info --log-mach=- -y --no-pause --no-restart-on-unexpected --install-fonts --no-headless --verify-log-full --binary=/home/test/build/firefox/firefox firefox

Some affected tests had slow results:

Slow tests

Test Result Longest duration (ms) Timeout (ms)
/css/css-page/page-margin-007-print.html FAIL 8501 10000

These may be pre-existing or newly slow tests. Slow tests indicate that a test ran very close to the test timeout limit and so may become TIMEOUT-flaky in the future. Consider speeding up the test or breaking it into multiple tests. For help, please tag @web-platform-tests/wpt-core-team in a comment.

@dev-ansung
Copy link
Contributor

Filed https://b.corp.google.com/issues/339099457
@KyleJu @DanielRyanSmith Could you please admin merge? Thanks

@KyleJu KyleJu merged commit 3e8ad40 into master May 6, 2024
15 of 17 checks passed
@KyleJu KyleJu deleted the chromium-export-cl-5513509 branch May 6, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants