css-multiple-display: Update serialization #39800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 2, 2023
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4493792
branch
from
4a77c3f to
2ddaf04
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4493792
branch
2 times, most recently
from
546bba7 to
b6073b3
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4493792
branch
2 times, most recently
from
a0e7c09 to
606a3d8
Compare
This CL follows resolutions of w3c/csswg-drafts#5575. * ParseDisplayMultipleKeywords() reorders and shortens keywords, but does not change the specified keywords to legacy keywords. It means - "el.style.display = 'block flow'; el.style.display" returns 'block'. - "el.style.display = 'flow-root inline'; el.style.display" returns 'inline flow-root', not 'inline-block'. * Display::ApplyValue() uses ValidateDisplayKeywords() Bug: w3c/csswg-drafts#5575 Bug: mozilla/wg-decisions#622 Bug: 995106 Change-Id: I6c916a8910b32f1d4849c68ac5595f9024bfa0f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4493792 Reviewed-by: Oriol Brufau <[email protected]> Auto-Submit: Kent Tamura <[email protected]> Commit-Queue: Kent Tamura <[email protected]> Cr-Commit-Position: refs/heads/main@{#1141725}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4493792
branch
from
606a3d8 to
d5b1e8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL follows resolutions of
w3c/csswg-drafts#5575.
ParseDisplayMultipleKeywords() reorders and shortens keywords, but
does not change the specified keywords to legacy keywords.
It means
'inline flow-root', not 'inline-block'.
Display::ApplyValue() uses ValidateDisplayKeywords()
Bug: w3c/csswg-drafts#5575
Bug: mozilla/wg-decisions#622
Bug: 995106
Change-Id: I6c916a8910b32f1d4849c68ac5595f9024bfa0f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4493792
Reviewed-by: Oriol Brufau <[email protected]>
Auto-Submit: Kent Tamura <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1141725}