Except where impractical, set Connection: Close with close_connection #38451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of the unexpected close, CFNetwork sometimes runs into a retry limit trying to find a working connection. Given we SHOULD be closing gracefully, and these tests are not attempting to test abrupt closure, it makes sense to just change these tests. The files not changed here are: tools/wptserve/wptserve/server.py tools/wptserve/wptserve/handlers.py tools/wptserve/wptserve/response.py fetch/h1-parsing/resources/status-code.py fetch/h1-parsing/resources/message.py See also web-platform-tests#38091.
wpt-pr-bot
requested review from
Manishearth,
annevk,
caitp,
hillbrad,
iVanlIsh,
igrigorik,
jdm,
mikewest,
mnot,
odinho,
plehegar,
wisniewskit,
yoavweiss,
youennf and
yutakahirano
annevk
approved these changes
Feb 13, 2023
Member
|
@abinpaul1 Chrome seems flaky on the Resource Timing |
foolip
approved these changes
Feb 14, 2023
Member
|
Admin merged by request from @gsnedders |
Contributor
|
@annevk I think it's tracked here : https://bugs.chromium.org/p/chromium/issues/detail?id=1399870 and is being looked at. |
marcoscaceres
pushed a commit
that referenced
this pull request
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the unexpected close, CFNetwork sometimes runs into a retry limit trying to find a working connection. Given we SHOULD be closing gracefully, and these tests are not attempting to test abrupt closure, it makes sense to just change these tests.
The files not changed here are:
tools/wptserve/wptserve/server.py
tools/wptserve/wptserve/handlers.py
tools/wptserve/wptserve/response.py
fetch/h1-parsing/resources/status-code.py
fetch/h1-parsing/resources/message.py
See also #38091.