Replace some assert_throws("Something", stuff) calls with assert_throws_dom #21377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
added
2dcontext
assets
content-security-policy
css-conditional
css-syntax
cssom
custom-elements
dom
domparsing
editing
feature-policy
fetch
FileAPI
generic-sensor
geometry
html
imagebitmap-renderingcontext
IndexedDB
infra
intersection-observer
media-source
mediacapture-image
mediacapture-record
offscreen-canvas
old-tests
payment-request
pointerevents
portals
selection
selectors
labels
wpt-pr-bot
requested review from
GPHemsley,
domenic,
domfarolino,
ewilligers,
fantasai,
foolip,
frivoal,
fserb,
fsoder,
gregwhitworth,
gsnedders,
guidou,
hayatoito,
henbos and
hillbrad
and removed request for
AmeliaBR,
ChrisParis,
andypaicu,
caitp,
danyao and
deniak
Contributor
|
Oh, yes, I expect this test: behaves differently if changed to |
Contributor
Author
|
Ok, results look good this time (modulo expected flake) |
stephenmcgruer
added a commit
that referenced
this pull request
Jan 25, 2020
#21377 used an approach which was known to cause indentation problems in some cases. This commit is an attempt to fixup any indentation issues, by running a (hacky) script to parse the diff and locate places where indentation was broken.
stephenmcgruer
added a commit
that referenced
this pull request
Jan 27, 2020
#21377 used an approach which was known to cause indentation problems in some cases. This commit is an attempt to fixup any indentation issues, by running a (hacky) script to parse the diff and locate places where indentation was broken.
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Feb 2, 2020
…actor, a=testonly Automatic update from web-platform-tests Fixup indentation from PR 21353 web-platform-tests/wpt#21353 used an approach which was known to cause indentation problems in some cases. This commit is an attempt to fixup any indentation issues, by running a (hacky) script to parse the diff and locate places where indentation was broken. -- Fixup indentation from PR 21354 web-platform-tests/wpt#21354 used an approach which was known to cause indentation problems in some cases. This commit is an attempt to fixup any indentation issues, by running a (hacky) script to parse the diff and locate places where indentation was broken. -- Fixup indentation from PR 21378 web-platform-tests/wpt#21378 used an approach which was known to cause indentation problems in some cases. This commit is an attempt to fixup any indentation issues, by running a (hacky) script to parse the diff and locate places where indentation was broken. -- Fixup indentation from PR 21379 web-platform-tests/wpt#21379 used an approach which was known to cause indentation problems in some cases. This commit is an attempt to fixup any indentation issues, by running a (hacky) script to parse the diff and locate places where indentation was broken. -- Fixup indentation from PR 21377 web-platform-tests/wpt#21377 used an approach which was known to cause indentation problems in some cases. This commit is an attempt to fixup any indentation issues, by running a (hacky) script to parse the diff and locate places where indentation was broken. -- Fixup indentation from PR 21390 web-platform-tests/wpt#21390 used an approach which was known to cause indentation problems in some cases. This commit is an attempt to fixup any indentation issues, by running a (hacky) script to parse the diff and locate places where indentation was broken. -- Fixup indentation from PR 21392 web-platform-tests/wpt#21392 used an approach which was known to cause indentation problems in some cases. This commit is an attempt to fixup any indentation issues, by running a (hacky) script to parse the diff and locate places where indentation was broken. -- wpt-commits: e4499c8ff1ecf603ecbda020102ec9c956d594f6, 88ab2f0e4965b8e6ea61d3ff4f90ff5215de8a4e, 21578f29a8e82eff91c0fd43ad709fbf3fbe9e72, e836541f46abbd9272233578ad4e8ac0867bde15, f2961a22018844dae808cb12af6774ba8b435773, 597c0519c494486d18ab81a32a7206014ee23b5a, 63c2f7190b779112aa79d28a51cc29b98ca381dc wpt-pr: 21422
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 5, 2020
…actor, a=testonly Automatic update from web-platform-tests Fixup indentation from PR 21353 web-platform-tests/wpt#21353 used an approach which was known to cause indentation problems in some cases. This commit is an attempt to fixup any indentation issues, by running a (hacky) script to parse the diff and locate places where indentation was broken. -- Fixup indentation from PR 21354 web-platform-tests/wpt#21354 used an approach which was known to cause indentation problems in some cases. This commit is an attempt to fixup any indentation issues, by running a (hacky) script to parse the diff and locate places where indentation was broken. -- Fixup indentation from PR 21378 web-platform-tests/wpt#21378 used an approach which was known to cause indentation problems in some cases. This commit is an attempt to fixup any indentation issues, by running a (hacky) script to parse the diff and locate places where indentation was broken. -- Fixup indentation from PR 21379 web-platform-tests/wpt#21379 used an approach which was known to cause indentation problems in some cases. This commit is an attempt to fixup any indentation issues, by running a (hacky) script to parse the diff and locate places where indentation was broken. -- Fixup indentation from PR 21377 web-platform-tests/wpt#21377 used an approach which was known to cause indentation problems in some cases. This commit is an attempt to fixup any indentation issues, by running a (hacky) script to parse the diff and locate places where indentation was broken. -- Fixup indentation from PR 21390 web-platform-tests/wpt#21390 used an approach which was known to cause indentation problems in some cases. This commit is an attempt to fixup any indentation issues, by running a (hacky) script to parse the diff and locate places where indentation was broken. -- Fixup indentation from PR 21392 web-platform-tests/wpt#21392 used an approach which was known to cause indentation problems in some cases. This commit is an attempt to fixup any indentation issues, by running a (hacky) script to parse the diff and locate places where indentation was broken. -- wpt-commits: e4499c8ff1ecf603ecbda020102ec9c956d594f6, 88ab2f0e4965b8e6ea61d3ff4f90ff5215de8a4e, 21578f29a8e82eff91c0fd43ad709fbf3fbe9e72, e836541f46abbd9272233578ad4e8ac0867bde15, f2961a22018844dae808cb12af6774ba8b435773, 597c0519c494486d18ab81a32a7206014ee23b5a, 63c2f7190b779112aa79d28a51cc29b98ca381dc wpt-pr: 21422
bhearsum
pushed a commit
to mozilla-releng/staging-firefox
that referenced
this pull request
May 1, 2025
…actor, a=testonly Automatic update from web-platform-tests Fixup indentation from PR 21353 web-platform-tests/wpt#21353 used an approach which was known to cause indentation problems in some cases. This commit is an attempt to fixup any indentation issues, by running a (hacky) script to parse the diff and locate places where indentation was broken. -- Fixup indentation from PR 21354 web-platform-tests/wpt#21354 used an approach which was known to cause indentation problems in some cases. This commit is an attempt to fixup any indentation issues, by running a (hacky) script to parse the diff and locate places where indentation was broken. -- Fixup indentation from PR 21378 web-platform-tests/wpt#21378 used an approach which was known to cause indentation problems in some cases. This commit is an attempt to fixup any indentation issues, by running a (hacky) script to parse the diff and locate places where indentation was broken. -- Fixup indentation from PR 21379 web-platform-tests/wpt#21379 used an approach which was known to cause indentation problems in some cases. This commit is an attempt to fixup any indentation issues, by running a (hacky) script to parse the diff and locate places where indentation was broken. -- Fixup indentation from PR 21377 web-platform-tests/wpt#21377 used an approach which was known to cause indentation problems in some cases. This commit is an attempt to fixup any indentation issues, by running a (hacky) script to parse the diff and locate places where indentation was broken. -- Fixup indentation from PR 21390 web-platform-tests/wpt#21390 used an approach which was known to cause indentation problems in some cases. This commit is an attempt to fixup any indentation issues, by running a (hacky) script to parse the diff and locate places where indentation was broken. -- Fixup indentation from PR 21392 web-platform-tests/wpt#21392 used an approach which was known to cause indentation problems in some cases. This commit is an attempt to fixup any indentation issues, by running a (hacky) script to parse the diff and locate places where indentation was broken. -- wpt-commits: e4499c8ff1ecf603ecbda020102ec9c956d594f6, 88ab2f0e4965b8e6ea61d3ff4f90ff5215de8a4e, 21578f29a8e82eff91c0fd43ad709fbf3fbe9e72, e836541f46abbd9272233578ad4e8ac0867bde15, f2961a22018844dae808cb12af6774ba8b435773, 597c0519c494486d18ab81a32a7206014ee23b5a, 63c2f7190b779112aa79d28a51cc29b98ca381dc wpt-pr: 21422
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a piece-by-piece landing of #21350 due to the size of the original PR. Please excuse the email spam when wpt-pr-bot cc's you to this PR.