Run DOM IDL tests in workers and convert to idl_test
#18688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of the use of variants it's unfortunately not possible to
merge this into a single test, but the duplication is not very
significant. Note that the use of `document.createEvent("Event")`
would make a merged test have non-trivial conditional setup too.
Member
Author
|
@lukebjerring FYI, or if you want to review. |
annevk
approved these changes
Aug 27, 2019
Member
annevk
left a comment
annevk
left a comment
There was a problem hiding this comment.
This seems fine to me. Maybe a comment explaining the setup would help, but if you put it in the commit message that's probably okay as well.
Contributor
|
172 new tests for the workers, and same counts for the existing tests, LGTM |
Contributor
|
@annevk - linked to the |
Member
Author
|
@annevk is the split between .window.js and .any.js the thing you wanted to see a comment on? |
Member
|
Yes, as it's not immediately clear why the redundancy is needed. |
Member
Author
|
I've sent #18708. |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Sep 9, 2019
… a=testonly Automatic update from web-platform-tests Fix the `test_tests_affected_null` test As the comment says, this "will fail if the file we assert is renamed", and that's what happened: web-platform-tests/wpt#18688 web-platform-tests/wpt#18743 Also change the commit to one which came after these changes, not because it makes a difference to the outcome but for anyone inspecting the commit to see the same files. -- wpt-commits: 253dcf4bc4a5d8bec265a4aa719a22f737777819 wpt-pr: 18819
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Sep 9, 2019
… a=testonly Automatic update from web-platform-tests Fix the `test_tests_affected_null` test As the comment says, this "will fail if the file we assert is renamed", and that's what happened: web-platform-tests/wpt#18688 web-platform-tests/wpt#18743 Also change the commit to one which came after these changes, not because it makes a difference to the outcome but for anyone inspecting the commit to see the same files. -- wpt-commits: 253dcf4bc4a5d8bec265a4aa719a22f737777819 wpt-pr: 18819
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
… a=testonly Automatic update from web-platform-tests Fix the `test_tests_affected_null` test As the comment says, this "will fail if the file we assert is renamed", and that's what happened: web-platform-tests/wpt#18688 web-platform-tests/wpt#18743 Also change the commit to one which came after these changes, not because it makes a difference to the outcome but for anyone inspecting the commit to see the same files. -- wpt-commits: 253dcf4bc4a5d8bec265a4aa719a22f737777819 wpt-pr: 18819 UltraBlame original commit: 8d708b174cd1f88246ad524d01a1ccc94f0cabd6
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
… a=testonly Automatic update from web-platform-tests Fix the `test_tests_affected_null` test As the comment says, this "will fail if the file we assert is renamed", and that's what happened: web-platform-tests/wpt#18688 web-platform-tests/wpt#18743 Also change the commit to one which came after these changes, not because it makes a difference to the outcome but for anyone inspecting the commit to see the same files. -- wpt-commits: 253dcf4bc4a5d8bec265a4aa719a22f737777819 wpt-pr: 18819 UltraBlame original commit: 8d708b174cd1f88246ad524d01a1ccc94f0cabd6
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 4, 2019
… a=testonly Automatic update from web-platform-tests Fix the `test_tests_affected_null` test As the comment says, this "will fail if the file we assert is renamed", and that's what happened: web-platform-tests/wpt#18688 web-platform-tests/wpt#18743 Also change the commit to one which came after these changes, not because it makes a difference to the outcome but for anyone inspecting the commit to see the same files. -- wpt-commits: 253dcf4bc4a5d8bec265a4aa719a22f737777819 wpt-pr: 18819 UltraBlame original commit: 8d708b174cd1f88246ad524d01a1ccc94f0cabd6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the use of variants it's unfortunately not possible to
merge this into a single test, but the duplication is not very
significant. Note that the use of
document.createEvent("Event")would make a merged test have non-trivial conditional setup too.
More details on the setup can be found in the documentation for idl_test helper method