Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the idl_test test_name argument (always 'idl_test setup') #12406

Merged
merged 2 commits into from
Aug 13, 2018
Merged

Remove the idl_test test_name argument (always 'idl_test setup') #12406

merged 2 commits into from
Aug 13, 2018

Conversation

foolip
Copy link
Member

@foolip foolip commented Aug 10, 2018

Completes what #12276 started.

lukebjerring
lukebjerring approved these changes Aug 10, 2018
View reviewed changes
Copy link
Contributor

@lukebjerring lukebjerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamping (code LGTM but haven't checked any tests locally). Consider using chromium to be sure of no regressions :)

P.S. the quantity of labels may cause you trouble on GitHub

@foolip
Copy link
Member Author

foolip commented Aug 13, 2018

I've tried the changes in https://chromium-review.googlesource.com/c/chromium/src/+/1172324 and see only expected changes, will merge here.

@foolip foolip merged commit a570eb1 into master Aug 13, 2018
@foolip foolip deleted the idl_test-test_name branch August 13, 2018 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukebjerring lukebjerring lukebjerring approved these changes

@annevk annevk Awaiting requested review from annevk

@darrnshn darrnshn Awaiting requested review from darrnshn

@dbaron dbaron Awaiting requested review from dbaron

@dholbert dholbert Awaiting requested review from dholbert

@dirkschulze dirkschulze Awaiting requested review from dirkschulze

@domenic domenic Awaiting requested review from domenic

@domfarolino domfarolino Awaiting requested review from domfarolino

@dontcallmedom dontcallmedom Awaiting requested review from dontcallmedom

@ewilligers ewilligers Awaiting requested review from ewilligers

@fantasai fantasai Awaiting requested review from fantasai

@fmarier fmarier Awaiting requested review from fmarier

@g-ortuno g-ortuno Awaiting requested review from g-ortuno

@garykac garykac Awaiting requested review from garykac

@grorg grorg Awaiting requested review from grorg

@gsnedders gsnedders Awaiting requested review from gsnedders

Assignees
No one assigned
Labels
accelerometer ambient-light appmanifest background-fetch BackgroundSync battery-status bluetooth content-security-policy cookie-store css-animations css-counter-styles css-font-loading css-images css-masking css-parser-api css-regions css-transitions css-typed-om cssom cssom-view domparsing fetch FileAPI filter-effects gamepad generic-sensor geolocation-sensor gyroscope html html-media-capture idlharness.js IndexedDB infra keyboard-lock keyboard-map magnetometer media-capabilities mediacapture-fromelement mediacapture-image mediacapture-record mediasession navigation-timing netinfo orientation-sensor page-visibility paint-timing payment-method-basic-card payment-request performance-timeline picture-in-picture pointerevents pointerlock proximity remote-playback resize-observer resource-timing screen-orientation selection subresource-integrity svg touch-events user-timing web-nfc web-share webaudio webauthn WebCryptoAPI webgl webrtc-stats webstorage webusb webxr wg-audio wg-css wg-das wg-payments wg-pointerevents wg-secondscreen wg-svg wg-webapps wg-webauthn wg-webcrypto wg-webevents wg-webperf wg-webplatform wg-webrtc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@foolip @lukebjerring @annevk @wpt-pr-bot