Only parse the stdout from direnv export json#42
Merged
wbolster merged 3 commits intowbolster:masterfrom May 11, 2019
Merged
Conversation
Then, put stderr into *direnv*. Side effect: exit code now only affects the warning message.
a normal message will not be visible when switching from a functional direnv directory to another broken one (e.g. unapproved .envrc), since the unloading of the first directory will be shown as a summary instead, causing the problem to go unnoticed. instead, use (warn ...) which will pop up a window instead.
wbolster
changed the title
Owner
|
done in b334a4a:
|
Owner
|
thanks @stribb! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Then, put stderr into
*direnv*.Side effect: exit code now only affects the warning message.
Tested:
Happy path: I ran
(direnv--export "/Users/andstrib/somedir")and it returns a list of environment key/value cons pairs.*direnv*contained the output and a line from stderr.Unhappy path: Then I changed the function to run
direnv export this-does-not-workand re-ran it. It didn't parse the error message, but did write to*Messages*and*direnv*.