Ability to set custom CSS, move style declaration to classes #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Eslint is reporting whitespace issues with code not related to this PR. I have fixed them anyway! |
Merged
|
@adrienkohlbecker While attempting to port in some of the updates in this PR into my fork, I found references to two new classes in render-wave-lane.js: The However, I would suggest What is your opinion? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I recently wanted to customize the styling of some of the elements in my diagrams. To do so, I needed to add custom CSS declarations to the output. This PR adds a
config.customStyleproperty to do so. If it is set, a<style type="text/css">property value</style>block is appended to the body.Additionally, overriding some of the default styles was made complicated by the use of inline styles. Indeed, CSS specificity rules dictate that inline styles have priority, unless you use
!importanteverywhere. So, to make it easier, I added classes on a few elements and moved inline styles to the main style block for each skin.