Tweak 1.4.10 Reflow understanding intent (cut off / zooming) #1819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Takes #326 (comment) as a starting point, but further clarifies the difference here between *overflowing* content (that is still reachable, but requires scrolling) and cut-off/hidden (is unreachable, basically `overflow:hidden` in CSS terms, or where scrolling has somehow been suppressed altogether) Closes #326
patrickhlauke
force-pushed
the
patrickhlauke-issue326
branch
from
29096d9 to
6cc6f95
Compare
|
Any news on this @alastc ? |
patrickhlauke
changed the title
mbgower
reviewed
Dec 5, 2023
|
@patrickhlauke given we've had several sessions about Reflow -- and I think @alastc is planning to bring it to discussion this week, I'm moving this back to In Progress. To me, it needs some tweaks in language. |
patrickhlauke
commented
Dec 12, 2023
patrickhlauke
commented
Dec 12, 2023
|
Let's delay on this one until the updates come through, @scottaohara can comment on whether/how to use it. |
|
Closing, as @scottaohara 's PR #4055 will take care of things more fundamentally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes #326 (comment) as a starting point, but further clarifies the difference here between overflowing content (that is still reachable, but requires scrolling) and cut-off/hidden (is unreachable, basically
overflow:hiddenin CSS terms, or where scrolling has somehow been suppressed altogether)In addition, this PR reformats the HTML indentation and uses a proper
<dl>for the examplesCloses #326