Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule to detect echidna deliverer change #1710

Merged
merged 17 commits into from
Mar 3, 2023
Merged

Add rule to detect echidna deliverer change #1710

merged 17 commits into from
Mar 3, 2023

Conversation

jennyliang220
Copy link
Contributor

Add rule deliverer-change to echidna files, resolves w3c/echidna#581

  • Use W3C API to get previous version's deliverer id

@jennyliang220 jennyliang220 requested a review from deniak February 28, 2023 08:49
lib/l10n-en_GB.js Outdated Show resolved Hide resolved
lib/rules/echidna/deliverer-change.js Show resolved Hide resolved
lib/rules/echidna/deliverer-change.js Outdated Show resolved Hide resolved
@jennyliang220 jennyliang220 requested a review from deniak March 3, 2023 06:18
lib/rules/echidna/deliverer-change.js Outdated Show resolved Hide resolved
@deniak deniak merged commit 25c225d into main Mar 3, 2023
@deniak deniak deleted the deliverer branch March 3, 2023 09:18
@deniak
Copy link
Member

deniak commented Mar 3, 2023

Thanks @jennyliang220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dry run doesn't report error with change of deliverers
2 participants