Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start changing to es6 modules #1530

Merged
merged 9 commits into from
Mar 16, 2022
Merged

Start changing to es6 modules #1530

merged 9 commits into from
Mar 16, 2022

Conversation

jennyliang220
Copy link
Contributor

@jennyliang220 jennyliang220 commented Feb 17, 2022

Migrate how the project is requiring dependencies. Mainly influence lib/ and test/ directory.
Use npm run start to start the app, or npm run live to live-reload when making changes.

Main changes:

// e.g. in app.js
import { importJSON } from './lib/util.js';
const { version } = importJSON('./package.json', import.meta.url);
  • Turn off import/extensions, although airbnb-code-style prefers it, it's using experimental features.

@jennyliang220 jennyliang220 marked this pull request as ready for review March 15, 2022 05:58
@jennyliang220 jennyliang220 requested a review from deniak March 15, 2022 05:58
Co-authored-by: Denis Ah-Kang <[email protected]>
@deniak deniak merged commit c418588 into main Mar 16, 2022
@deniak deniak deleted the es6_import branch March 16, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants