Update button and input button allowances #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #444 closes #395 closes #298 This PR makes the allowances for button-elements (button, input type=button|image|submit|reset) more consistent with each other. Additionally, slider and gridcell are now listed under the allowed roles for these elements. the LOE to properly create the necessary UX for some of these roles when specified, especially on the `input` type buttons, is rather large _but_ possible. Any failures to not implement these properly would be caught by WCAG rules. Allowing the roles won't change that.
scottaohara
added
needs implementation commitment
scottaohara
added a commit
that referenced
this pull request
Feb 6, 2023
incorporates feedback from steve and sarah. includes language "the following roles are allowed, but are NOT RECOMMENDED" to introduce new allowed roles which _can_ work depending on what's been built, but there are probably better ways to do this. This wording is also used in #446, and allows for us to indicate these changes per element, without having to restructure the entire table (as this can be the end goal, rather than trying to get all allowed roles for all elements updated at once).
scottaohara
added
the
Allowed roles
stevefaulkner
approved these changes
Feb 6, 2023
This was referenced Feb 15, 2023
Open
Closed
scottaohara
added
Meets 2 implementations req
and re-simplify input type=image rules. now all button elements have the same rules, even though type=image is likely to be more trouble than it's worth for authors to use, correctly and without other wcag related issue.
scottaohara
removed
the
needs changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #444
closes #395
closes #298
These PR supersedes #405
This PR makes the allowances for button-elements (button, input type=button|image|submit|reset) more consistent with each other. Additionally, slider and gridcell are now listed under the allowed roles for these elements.
the LOE to properly create the necessary UX for some of these roles when specified, especially on the
inputtype buttons, is rather large but possible. Any failures to not implement these properly would be caught by WCAG rules. Allowing the roles won't change that.(the issues for each of these checkers are referenced later in this thread)
button and input type=button test cases and
input type=reset, image, submit test cases
Preview | Diff